Commit Graph

8363 Commits

Author SHA1 Message Date
Richard Hughes
fbb6f7fd66 Speed up regenerating the MOTD
This is regenerated on every device hotplug event, and although infrequent
there is no point doing all that CPU-heavy requirement checking for no reason.
2023-02-08 04:20:57 +00:00
Richard Hughes
9fdfcfe499 wistron-dock: Use only-wait-for-replug to speed up device replug
Also, set the progress steps correctly.
2023-02-07 11:24:03 +00:00
Richard Hughes
70417a3aee wistron-dock: Fix critical warning during update 2023-02-07 11:24:03 +00:00
Richard Hughes
9b75eb9e34 trivial: Only use clang-format on C source files 2023-02-07 11:01:22 +00:00
Richard Hughes
4257d5f451 Add support for Quit() in fwupdmgr
This allows us to only shut down the P2P daemon in the installed tests.
The easy fix would have been to use something like:

    gdbus call --address unix:path=/run/fwupd.sock --object-path / --method org.freedesktop.fwupd.Quit'

...but the daemon does not implement an ObjectManager, which gdbus requires.

This worked correctly for so long because the p2p tests were being run after
the bus tests, so shutting down the system daemon had no effect.

Fedora 37 seems to have flipped the order for some reason -- and now it
*sometimes* matters that we were doing the worng thing...
2023-02-07 11:00:53 +00:00
Richard Hughes
d4109b9f79 trivial: Fix Fedora CI when it cannot autostart udisks 2023-02-07 11:00:53 +00:00
Richard Hughes
7116ff94c2 cros-ec: Clear the bulk transfer buffer to zero before using
This allow us to emulate the device as the buffer contents are now 100%
predictable and replayable.
2023-02-07 09:30:51 +00:00
Richard Hughes
986b811b3d trivial: Fix a tiny coverity-spotted memory leak on error 2023-02-06 10:24:03 +00:00
Richard Hughes
255ca3d513 Move the Fedora CI job to F37 2023-02-04 17:28:07 +00:00
Richard Hughes
4edf2c5079 Use the correct range check when parsing SMBIOS
The SMBIOS specification says:

    Maximum size of SMBIOS Structure Table, pointed to by the
    Structure Table Address, in bytes. The actual size is guaranteed
    to be less or equal to the maximum size.

So, the firmware is actually allowed to return a DMI blob smaller than the
specified size.

Fixes https://github.com/fwupd/fwupd/issues/5486
2023-02-04 12:55:22 +00:00
Richard Hughes
aef162223f nvme: Detect and warn users with the broken firmware 3B2QGXA7 2023-02-03 17:31:42 +00:00
Richard Hughes
f3bf12dd1c trivial: Fix fu-self-test with libgusb from the main branch 2023-02-03 17:25:03 +00:00
Richard Hughes
c6a3a6e82c trivial: Fix critical warning when loading an emulated DFU device 2023-02-03 16:53:48 +00:00
Richard Hughes
d2082a5f3b Revert "trivial: Fix clang-format of JSON files for newer versions of clang"
This reverts commit 2eb4357a70.
2023-02-03 15:43:04 +00:00
Richard Hughes
2eb4357a70 trivial: Fix clang-format of JSON files for newer versions of clang
This explains why Mario and I had different precommit settings.
2023-02-03 14:28:44 +00:00
Richard Hughes
b3343755a4 ti-tps6598x: Ignore the 'wrong' USB device class before calling ->setup()
No functional change, but a few less i/o operations when inserting the dock.
2023-02-02 08:18:28 +00:00
Valentin David
845425c34a snap: Use common directory for vendor path 2023-02-01 20:44:56 -06:00
Valentin David
995c3210b1 snap: Use strict confinement 2023-02-01 20:44:56 -06:00
Valentin David
df2569f2c3 snap: Fix a meson parameter 2023-02-01 20:44:56 -06:00
Valentin David
d703580411 snap: Remove some unused/redundant dependencies 2023-02-01 20:44:56 -06:00
Valentin David
f647b38e11 snap: Remove dconf 2023-02-01 20:44:56 -06:00
Valentin David
13d6b671ab snap: Add missing libraries 2023-02-01 20:44:56 -06:00
Valentin David
429c4ff2a6 Optionally disable Polkit check with an environment variable
When running in a confined snap, it is not possible to check whether a
policies have been installed.
2023-02-01 20:44:56 -06:00
Valentin David
5ce5080844 Allow overriding lock directory with an environment variable 2023-02-01 20:44:56 -06:00
Richard Hughes
b8631d5e4d dfu: Use more const buffer data when writing to AVR chips 2023-02-01 18:20:26 +00:00
Richard Hughes
add087966d dfu: Clear the buffer before getting the status
This makes emulation of DFU devices work as the control transfer data is then
predictable.
2023-02-01 18:20:26 +00:00
Richard Hughes
8ed6a52ca4 trivial: Enable USB debugging when backend debugging is enabled 2023-02-01 16:42:51 +00:00
Richard Hughes
e3197cc71e trivial: Use new API in libgusb to better detect USB replug 2023-02-01 16:42:51 +00:00
Richard Hughes
99df74f0c2 Add API to wait for a device
This allows us to ignore all the delays when the device is emulated, with the
idea being to do dozens of device emulations in the CI tests.

Also, do not call fu_progress_sleep() when the device is emulated.
2023-02-01 09:42:08 +00:00
Richard Hughes
654dd756b7 Do not invalidate the probe for emulated devices
If the device does not replug, and we change the GUsbDevice because the phase
changed we don't want reprobe the hardware.

If we reprobe then the emulated device will request extra data compared to the
real device, which will cause emulation to fail.
2023-01-31 16:58:31 +00:00
Richard Hughes
b44ee4cf54 trivial: Require --force to overwrite files with 'fwupdmgr download' 2023-01-31 16:28:00 +00:00
Richard Hughes
914f636aa6 Return an error when the pending db could not be updated 2023-01-31 13:27:56 +00:00
dependabot[bot]
3df5bf7bde build(deps): bump docker/build-push-action from 3 to 4
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-01-31 08:25:11 +00:00
Richard Hughes
fafc4bc740 trivial: Do not hardcode fwupdmgr as a binary name 2023-01-30 17:33:35 -06:00
Richard Hughes
e130735207 trivial: Record the install phase for future functionality 2023-01-30 15:12:06 +00:00
Richard Hughes
3881b6ffae trivial: Do not inherit history from emulated devices 2023-01-30 15:12:06 +00:00
Richard Hughes
c5b81559e9 trivial: Remove some dead comments left in after debugging 2023-01-30 15:12:06 +00:00
Richard Hughes
32d6c7f8dd Use indexes when building the quirk prepared queries
This can save 250us on each query (of which we do a *lot*), and reduces the
number of queries by about half if the user is using a libxmlb version that can
convert from `_BOUND_TEXT` to `_BOUND_INDEX_TEXT`.

The more devices detected, the bigger the difference, and without this patch
fixing libxmlb would break fwupd as we'e been searching with an index, but not
actually providing one.
2023-01-30 14:47:56 +00:00
Richard Hughes
6e34a90a12 trivial: Add FuProgress to fu_context_load_hwinfo()
TIL: fu_bios_settings_setup() takes over 50ms (10%!) at startup.
2023-01-30 14:47:44 +00:00
Richard Hughes
4d4c56fa75 trivial: Remove duplicate call to fu_engine_ensure_device_supported()
This is moderately expensive to call as it processes each requirement on each
release on each device, so the last thing we want to do is call it *twice*.
2023-01-30 14:47:44 +00:00
Richard Hughes
d6bb00a475 trivial: Update all fixes using markdownlint 2023-01-30 14:19:59 +00:00
Richard Hughes
b9da5362a0 trivial: Update all fixes using codespell 2023-01-30 14:19:59 +00:00
Richard Hughes
00e8aaefc6 Use a more compact JSON format using precommit 2023-01-30 14:19:59 +00:00
Richard Hughes
c1ffebae48 Remove unused API for setting backend tags
It turns out we do not want to know the current phase of the device, and we can
achieve the same thing tagging the GUsbDevice manually and clearing the events
at exactly the correct time.
2023-01-30 13:32:48 +00:00
Richard Hughes
234ff36cff ti-tps6598x: Assign the DMC as the proxy rather than just the parent
We 'write through' the parent, and by telling fwupd this we can make better
decisions when emulating.
2023-01-30 12:00:04 +00:00
Richard Hughes
047b093904 Copy some flags from the proxy to the logical device 2023-01-30 12:00:04 +00:00
Mario Limonciello
3f105cf9ec trivial: update fwupd-efi to 1.4
fwupd-efi 1.4 enforces that NX bit is set by default.
This won't affect most users, it should only affect those that compile
by hand and don't have fwupd-efi installed already.
2023-01-27 10:15:14 -06:00
Richard Hughes
70fb80cc64 trivial: Do not ask for polkit auth if the device is emulated 2023-01-27 15:47:44 +00:00
Richard Hughes
0e1d7608b3 trivial: Do not wait for the acquiesce delay if emulated 2023-01-27 15:47:44 +00:00
Frédéric Danis
3dcf24cae0 Propagate device tag to parent device 2023-01-26 15:37:35 +01:00