proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-06 09:00:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use the correct range check when parsing SMBIOS

Browse Source 
The SMBIOS specification says:

    Maximum size of SMBIOS Structure Table, pointed to by the
    Structure Table Address, in bytes. The actual size is guaranteed
    to be less or equal to the maximum size.

So, the firmware is actually allowed to return a DMI blob smaller than the
specified size.

Fixes https://github.com/fwupd/fwupd/issues/5486
This commit is contained in:
Richard Hughes 2023-02-04 12:46:03 +00:00
parent aef162223f
commit 4edf2c5079
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libfwupdplugin/fu-smbios.c
View File

@ -325,7 +325,7 @@ fu_smbios_setup_from_path(FuSmbios *self, const gchar *path, GError **error)
dmi_fn = g_build_filename(path, "DMI", NULL);
if (!g_file_get_contents(dmi_fn, &dmi_raw, &sz, error))
return FALSE;
if (sz != self->structure_table_len) {
if (sz > self->structure_table_len) {
g_set_error(error,
FWUPD_ERROR,
FWUPD_ERROR_INVALID_FILE,