Commit Graph

6871 Commits

Author SHA1 Message Date
Gaël PORTAY
ad3cf1874a genesys: Fix typo in README.md
The device name HP USB-C Controller.
2022-03-23 20:46:39 +00:00
Gaël PORTAY
9ff6c88acf genesys: usbhub: Prefix error at probe
For the sake of consistancy.
2022-03-23 20:00:33 +00:00
Gaël PORTAY
3be9fbb301 genesys: usbhub: Fail silently if unsupported IC type
Genesys Logic uses the same VID/PID for its USB Hubs products, whatever
the chip underneath (GL3523, GL3590...). For example, Genesys Logic
USB2.0 Hub uses 05E3/0610; and Genesys Logic USB3.1 Hub uses 05E3/0612.

The manufacturers may reuse the Genesys Logic VID/PID for its products
or may use its own VID such as HP (03F0).

The genesys plugin supports upgrading GL3523 USB and GL3590 USB2.0 Hubs
for now (the latter is not tested).

The quirk file limits the support to HP Hubs only; and the plugin will
allow upgrade Hub with genuine Genesys Logic VID/PID in the future by
adding the following lines to the quirk file:

	[USB\VID_05E3&PID_0610]
	Plugin = genesys

However, this change in the quirk file will report the errors below for
the Hub with IC that are not supported:

	04:26:40:0325 FuEngine             failed to add device usb:01:00:01: Unsupported IC GL3521-22
	04:26:40:0344 FuEngine             failed to add device usb:01:00:01: Unsupported IC GL3521-22

Note: This may be true already if HP uses Hubs with IC that are not
unsupported.

This change returns the error FWUPD_ERROR_NOT_SUPPORTED instead to fail
silently.
2022-03-23 20:00:33 +00:00
Gaël PORTAY
fa7c297b98 genesys: usbhub: Print unsupported IC type
This rewords the error message to print the unsupported IC type.
2022-03-23 20:00:33 +00:00
Gaël PORTAY
128caa5388 Fix memory leak
This fixes the memory leak below:

	$ sudo valgrind -v --leak-check=full fwupdtool get-devices
	(...)
	==3244345== 133 (64 direct, 69 indirect) bytes in 2 blocks are definitely lost in loss record 2,488 of 2,681
	==3244345==    at 0x4845899: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
	==3244345==    by 0x4C04D59: g_malloc (in /usr/lib/libglib-2.0.so.0.7000.4)
	==3244345==    by 0x4C1C816: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.7000.4)
	==3244345==    by 0x4C1CE9E: g_slice_alloc0 (in /usr/lib/libglib-2.0.so.0.7000.4)
	==3244345==    by 0x4B84684: g_type_create_instance (in /usr/lib/libgobject-2.0.so.0.7000.4)
	==3244345==    by 0x4B6BB65: ??? (in /usr/lib/libgobject-2.0.so.0.7000.4)
	==3244345==    by 0x4B6CAF4: g_object_new_with_properties (in /usr/lib/libgobject-2.0.so.0.7000.4)
	==3244345==    by 0x4B6D659: g_object_new (in /usr/lib/libgobject-2.0.so.0.7000.4)
	==3244345==    by 0x4AA8969: ??? (in /usr/lib/libgio-2.0.so.0.7000.4)
	==3244345==    by 0x153967: fu_engine_load_local_metadata_watches (fu-engine.c:7050)
	==3244345==    by 0x1540FC: fu_engine_load (fu-engine.c:7230)
	==3244345==    by 0x124D29: fu_util_start_engine (fu-tool.c:262)
	(...)
	==3244345== LEAK SUMMARY:
	==3244345==    definitely lost: 64 bytes in 2 blocks
	==3244345==    indirectly lost: 69 bytes in 2 blocks
	==3244345==      possibly lost: 1,936 bytes in 8 blocks
	==3244345==    still reachable: 234,668 bytes in 3,072 blocks
	==3244345==         suppressed: 0 bytes in 0 blocks
	==3244345== Reachable blocks (those to which a pointer was found) are not shown.
	==3244345== To see them, rerun with: --leak-check=full --show-leak-kinds=all
	==3244345==
	==3244345== ERROR SUMMARY: 9 errors from 9 contexts (suppressed: 0 from 0)
2022-03-23 19:05:20 +00:00
Gaël PORTAY
333c32a8e0 genesys: Fix memory leak 2022-03-23 17:22:53 +00:00
Richard Hughes
b99297046f Check the update protocol exists when checking requirements 2022-03-23 16:34:09 +00:00
Richard Hughes
aaa5606950 upower: Support the new PENDING device states 2022-03-23 09:06:54 +00:00
Richard Hughes
3ca8c915e2 nvme: Add signed-payload quirks for Kingston 2022-03-22 17:22:37 +00:00
Richard Hughes
8a349e17af Include macos-10.15 and macos-11 in CI builds 2022-03-22 14:57:08 +00:00
Richard Hughes
2bee2164af trivial: Fix the mtd test when the prefix is read only 2022-03-22 14:36:48 +00:00
Richard Hughes
afab41bcf5 ccgx: Add alternate protocol names
Cypress was acquired by Infineon.
2022-03-22 14:34:15 +00:00
Richard Hughes
179dae4823 Do not throw away the TPM eventlog when uploading to the LVFS
To debug the eventlog reconstruction issues we need the raw blob,
rather than just the printable text.
2022-03-22 14:31:54 +00:00
Ivan Mikhanchuk
e3907a116e modem-manager: add Quectel EM05 firwmare update support
EM05 switches to the EDL mode over MBIM port, then uses
Sahara to load a firehose binary. The firmware is loaded to
the modem using Firehose protocol.
2022-03-22 14:26:49 +00:00
Ivan Mikhanchuk
6fa82b10bc modem-manager: add Sahara IO functions to Firehose 2022-03-22 14:26:49 +00:00
Ivan Mikhanchuk
27a68de8ee modem-manager: add Sahara protocol 2022-03-22 14:26:49 +00:00
Ivan Mikhanchuk
716a47db8c modem-manager: move firehose related functions to one 2022-03-22 14:26:49 +00:00
Ivan Mikhanchuk
ee71e5ffa9 modem-manager: fix fu_chunk padding in firehose 2022-03-22 14:26:49 +00:00
Ivan Mikhanchuk
387b797c6f modem-manager: add get_mbim_device method for MbimQdu 2022-03-22 14:26:49 +00:00
Gaël PORTAY
7fc784d612 genesys: scaler: Get real software version
The plugin gets the panel-type (i.e. hardware revision) as the firmware
version.

This gets the real firmware version, and appends the panel-type to the
instance-id string as the blobs are specific to panel-types.
2022-03-22 14:20:37 +00:00
Gaël PORTAY
388fadc347 genesys: scaler: Fix Special Protect Sector structure length
The Special Protect Sector structure is 24-bit long.

This replaces the 32-bit integer in union that makes the structure
8-bits too big by an array of 3-bytes.
2022-03-22 14:19:48 +00:00
Gaël PORTAY
41ab816fed genesys: scaler: Fix creation of error
The GError object is not yet created, and cannot be prefixed though.

This creates the GError using the function g_set_error().
2022-03-22 14:19:48 +00:00
Richard Hughes
4afdfcb034 trivial: Use a glib2 with the EPERM patch to fix CI 2022-03-22 14:18:06 +00:00
Richard Hughes
c29f64adc4 trivial: Bump the win32 build to Fedora 36 2022-03-22 14:18:06 +00:00
Richard Hughes
baa7fde32c trivial: Add one extra mingw package to fix CI 2022-03-22 14:18:06 +00:00
Richard Hughes
b43bf44e13 trivial: Fix FreeBSD CI build harder 2022-03-21 08:43:30 +00:00
memily
8141061a9a
vli: Move more devices out of the installed list
These devices will probably never get updates from the LVFS.
2022-03-19 10:16:59 +00:00
Daniel Campello
f58217a0ab thunderbolt: add configuration option to force retimer enumeration
Change-Id: I300b94291d6d989b4b1c88daaadc5f0f49ac88be
2022-03-18 14:26:34 -06:00
Richard Hughes
8624f454d6 trivial: Remove one instance of -Wunused-variable 2022-03-18 13:35:57 +00:00
Richard Hughes
8ef261af32 mtd: Add some self tests using mtdram 2022-03-18 12:55:44 +00:00
Richard Hughes
df66a1d73e mtd: Ignore devices that report EPERM on open 2022-03-18 12:55:44 +00:00
Richard Hughes
7d9dff4789 mtd: Support dumping the image to a firmware blob 2022-03-18 12:55:44 +00:00
Richard Hughes
095cbad100 mtd: Fix writing mtd images larger than 10kb 2022-03-18 12:55:44 +00:00
Richard Hughes
5a3010f525 ata: Add signed-payload for Phison devices 2022-03-18 12:54:39 +00:00
Richard Hughes
84a13af360 Show the user a wiki page about the FDE warning
Fixes https://github.com/fwupd/fwupd/issues/4400
2022-03-18 12:11:40 +00:00
Richard Hughes
a11fefff35 redfish: Don't add the backup BMC device as it shares the same GUIDs
This fixes the problem when the UEFI update depends on a specific BMC
version -- including the backup BMC device means we checking that both
the primary and the backup were above a specific version.

I don't think it's ever useful to show the backup BMC device, so just
don't include it as an enumerated device.

Fixes https://github.com/fwupd/fwupd/issues/4404
2022-03-18 11:03:14 +00:00
Richard Hughes
41bc319331 trivial: Fix -Wundef warning when compiling without libcbor 2022-03-18 10:38:12 +00:00
Richard Hughes
e9454e022f logitech-bulkcontroller: Mark as signed payload 2022-03-17 20:46:43 +00:00
Richard Hughes
4074150d21 trivial: Convert the FreeBSD cbor requirement to a LIB depends 2022-03-17 13:19:43 +00:00
Richard Hughes
b9774c644d Fix the 'Device has been removed' warning incorrectly seen on devices
Uninhibit the returning device if no firmware update has been performed.
2022-03-17 10:06:37 +00:00
Sean Rhodes
d8b6f5f0b3
plugin/flashrom: Change the default format from triplet to pair (#4395)
Flashrom is primarily used with coreboot, which has a pair version number
currently 4.16. As such, chance the default to pair so that fewer quirks
are required.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
2022-03-17 07:58:25 +00:00
Tatsunosuke Tobita
a61f4ec1af plugins/wacom-raw: Add several Lenovo products
wacom-raw is required to support several Lenovo products.
Therefore, some items have been added to "wacom-raw.quirk".

Signed-off-by Tatsunosuke Tobita <tatsunosuke.tobita@wacommfg.corp-patner.google.com>
2022-03-16 18:34:22 -05:00
Richard Hughes
71d111a21f gpio: Return the correct error when there is no device to open 2022-03-16 12:08:32 +00:00
Richard Hughes
013475fc49 trivial: Actually open the GPIO device before querying the chipinfo
Set the GPIO open flags as without the fd is not opened.

Fixes https://github.com/fwupd/fwupd/issues/4388
2022-03-16 12:08:32 +00:00
Sean Rhodes
57862d844e
plugin/flashrom: Add GUIDs for StarLite's (#4392)
* HwId for StarLite Mk IV
* coreboot GUID for StarLite Mk IV
* HwId for StarLite Mk II (under coreboot)
* coreboot GUID for StarLite Mk II

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
2022-03-16 10:18:20 +00:00
Richard Hughes
da37d93eb0 trivial: Remove some long dead docs about fu_plugin_device_add_delay() 2022-03-16 09:18:29 +00:00
Richard Hughes
8b62bf6b64 Set the context in the right place more often 2022-03-16 09:18:29 +00:00
Richard Hughes
945002f7a3 Fix build for MacOS
This is more for curiosity than anything else.
2022-03-15 14:37:28 +00:00
Richard Hughes
92515d193a Add coSWID and uSWID parsers to libfwupdplugin
These parse the structures as defined in:

 * https://datatracker.ietf.org/doc/draft-ietf-sacm-coswid/
 * https://github.com/hughsie/python-uswid
2022-03-15 14:37:02 +00:00
Richard Hughes
6b5d933e99 Do not show unconnected or unreachable devices in the client tools
Fixes https://github.com/fwupd/fwupd/issues/4378
2022-03-15 14:08:17 +00:00