Mario Limonciello
542b97d19f
dell: Set parents for Dell WD15/TB16 docks
2018-05-03 08:07:04 +01:00
Mario Limonciello
4a981d599c
dell: Set TPM alternate mode device under regular mode
2018-05-03 08:07:04 +01:00
Richard Hughes
b01b4869bb
trivial: Use fu_plugin_add_runtime_version() in the Dell plugin
2018-04-20 20:45:08 +01:00
Mario Limonciello
a98df55d82
Disable -Wunused-function on clang builds ( Closes #467 )
...
GLib creates two static inline functions for paramaters that may
not be used that set off warnings in clang but not gcc.
Ignore these on clang builds everywhere that
G_DEFINE_AUTOPTR_CLEANUP_FUNC is used.
2018-04-17 10:10:43 +01:00
Sjoerd Simons
9f10cbacaf
Set Dell dock metadata
...
On Dell dock devices set the FU_DEVICE_METADATA_DELL_DOCK_TYPE metadata
field which gets used by the synapticsmst plugin for recognizing dell
dock types.
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
2018-04-10 15:57:59 -05:00
Mario Limonciello
e37cd0d8ce
dell: Report Libsmbios version in metadata
2018-02-06 19:29:28 +00:00
Mario Limonciello
9f932edaca
trivial: dell: blacklist another system when used with older libsmbios
...
The reporter confirmed that changes in libmsbios 2.4.0 fix the problem
however.
Bug: https://bugs.launchpad.net/ubuntu/+source/libsmbios/+bug/1744782
2018-01-31 13:59:42 -06:00
Mario Limonciello
3780bb5c0d
dell: Add a test for libsmbios version
...
This will be useful in the future for debugging crashes with known
problematic versions of libsmbios.
Also use this information to turn off the blacklist from previously
bad known combinations of libsmbios + certain systems
2018-01-27 22:48:36 -06:00
Richard Hughes
2de8f13b2c
Allow each plugin to opt-in to the recoldplug action
...
Recoldplug is really not required for the USB based plugins, and we should
restrict this action to plugins that have inter-dependencies on each other.
2018-01-17 20:19:58 +00:00
Mario Limonciello
736be7440f
dell: block owned TPM updates ( #339 )
...
Also make it clearer what the logic is checking.
2017-12-13 12:13:33 -06:00
Richard Hughes
23135eb1c9
trivial: Remove the now-unused fu_plugin_set_status()
2017-12-04 17:00:22 +00:00
Richard Hughes
4a036018f7
Set the progress and state on the FuDevice, not the FuPlugin
...
This makes more sense; we're updating the device, not the plugin itself.
This also means we don't need to funnel everything through callbacks like
GFileProgressCallback and we can also update the state without adding an
explicit callback to each derived device type.
2017-11-30 20:51:52 +00:00
Richard Hughes
d0cff7caec
Remove autoconf-isms from the meson configure options
...
See https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
2017-11-27 18:07:53 +00:00
Jan Tojnar
cc9f934787
build: Refactor directory selection
...
Previously, the various install paths were obtained using get_option
as needed.
This patch unifies the directory selection inside the top-level meson
file as requested in https://github.com/hughsie/colord/pull/62 .
2017-11-17 17:11:51 +00:00
Mario Limonciello
2e52dc2242
dell: disable plugin if libsmbios fails
2017-11-14 13:20:59 -06:00
Mario Limonciello
20e856ccbe
dell: activate libsmbios_c debugging output with --plugin-verbose=dell
2017-11-14 12:00:49 -06:00
Richard Hughes
a14d771476
dell: Fix a trivial warning spotted by clang
2017-11-09 12:15:55 +00:00
Mario Limonciello
7f3bfc9d99
dell: catch invalid dock component requests
...
Test if g_strrstr returns NULL, as this means the string was
modified and other requests predicated on this will fail miserably.
2017-11-07 09:46:36 -06:00
Mario Limonciello
3164784d9e
dell: fix crashes when enumerating with dock connected but UEFI capsule off
...
Crashes will happen when UEFI capsule is turned off due to fwupdate
trying to do a SMI request that invalidates the buffer used by fwupd.
This is due to both fwupdate and fwupd using libsmbios in the same process.
Fixes: https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1726367
2017-11-07 09:46:36 -06:00
Richard Hughes
74a80ccc50
dell: Use the new quirk infrastructure for version numbers
2017-11-02 19:08:51 +00:00
Mario Limonciello
bd0f3f8920
rename fu-dell-common to fu-dell-smi
...
Since it's not being used by other plugins, make it represent
what it really does now.
2017-10-18 08:27:54 -05:00
Mario Limonciello
7af941fee4
synaptics: drop hard dependency on dell plugin and libsmbios
...
Rather than have a hard dependency use metadata and internal DMI
to communicate the relevant details
2017-10-18 08:27:38 -05:00
Mario Limonciello
ed538c2b84
drop fu_dell_get_cable_type, unused
2017-10-18 08:22:43 -05:00
Richard Hughes
4212f40e9d
trivial: Fix failure to build on i386
2017-10-09 12:17:02 +01:00
Mario Limonciello
26767845f1
trivial: dell: add missing icon for TPM devices
2017-09-28 10:25:30 -04:00
Mario Limonciello
5a8e8ee88d
dell: only set coldplug delay when we know we need it
...
It's not very common to have a system with a Synaptics MST hub or
a dock plugged in. Avoid slowing down fwupd enumeration in the
common scenario.
2017-09-26 08:56:07 -04:00
Mario Limonciello
e401edd107
dell: only run SMI to toggle host MST GPIO on systems with host MST
...
As type-C docks become more common MST controllers in the host are
going to become rarer. This should be a manageable whitelist
and prevent running the SMI on the majority of systems.
2017-09-26 08:56:07 -04:00
Mario Limonciello
5a3ff3a446
trivial: dell create a function for looking up system ID
...
Enough places look for it that code duplication should go away.
2017-09-26 08:56:07 -04:00
Mario Limonciello
48cae2cb5e
dell: add functionality to blacklist HW with problems
...
This is certainly a problem lower in the stack, but at least provide
a method to block these systems from bringing down fwupd until it's
fixed.
2017-09-26 08:56:07 -04:00
Mario Limonciello
e0e6a0b885
dell: only run on intended chassis
...
For example if trying to run on a server, they might support some
dell SMI but are architected differently.
2017-09-26 08:56:07 -04:00
Mario Limonciello
39c4436c3d
trivial: dell: move fu_dell_supported into plugin
...
Eventually fu-dell-common will not be used by synaptics, and it's
already not using this function.
2017-09-21 06:23:24 +08:00
Mario Limonciello
1edb50ed2f
trivial: dell: remove needless includes
2017-09-20 09:11:02 -05:00
Mario Limonciello
9a30ef284d
dell: prefer to use hwids to get DMI keys and DE table
...
libsmbios is still used as a fallback in some cases, mostly
because it's not clear whether or not ProductSKU is available
in all instances.
2017-09-20 09:11:02 -05:00
Mario Limonciello
9ff5670b3d
drop fu-dell-tool
...
It's been superceded by the thunderbolt power plugin
2017-09-18 17:13:12 -05:00
Richard Hughes
9decf17d82
dell: Fix a trivial whitespace issue
2017-09-16 18:52:44 +01:00
Mario Limonciello
9d84b22d7b
dell: drop thunderbolt force power code
...
This is replaced by the WMI force power interface.
2017-09-13 03:12:50 +08:00
Richard Hughes
c1c2fec6f5
Add optional icons to each device
...
This allows us to show the devices in a GUI with a nice icon. Some of the icon
mappings are not perfect and I'll be asking the GNOME designers for some
additions to the icon specification.
Custom vendor icons can also be specified, and /usr/share/fwupd/icons would be
a good place to put them. If vendor icons are used they should show a physical
device with the branding, rather than just the vendor logo.
2017-09-11 17:27:35 +01:00
Richard Hughes
9bfcfd88cf
Ensure more devices set the device summary
...
This helps users identify what the device actually does.
2017-09-11 15:10:50 +01:00
Richard Hughes
5720fc9d90
trivial: Add more vendor information to devices
2017-09-11 10:11:34 +01:00
Richard Hughes
7ac92109eb
trivial: Remove useless config.h defines
...
The HAVE_UEFI_UNLOCK and HAVE_UEFI_GUID defines are always present for the
libfwup version we require.
2017-09-06 23:07:50 +01:00
Mario Limonciello
bb9d3b14dd
Revert "dell: prefer to detect supported systems from OEM strings"
...
This reverts commit 257c14ebd1
.
Although this is the preferable way to detect Dell systems this was
leading to executing SMI on some systems with problems.
libsmbios has some memory issues that need to be fixed first.
2017-08-31 16:48:45 -05:00
Mario Limonciello
a65ce8392b
trivial: use fu_device_has_flag instead of fwupd_device_has_flag
2017-08-31 13:11:27 -05:00
Mario Limonciello
d63e7317db
trivial: dell: turn device back on for thunderbolt plugin, not tbtfwu plugin
2017-08-31 13:00:32 -05:00
Mario Limonciello
c2ed0cb2bc
trivial: update remaining use of ALLOW_ONLINE to UPDATABLE
2017-08-31 12:59:26 -05:00
Richard Hughes
e655008a73
trivial: Fix starting conditions in the self tests
...
Found using Coverity.
2017-08-30 15:06:06 +01:00
Richard Hughes
b95b75a211
trivial: Remove unused function in the dell plugin
...
Fixes: https://github.com/hughsie/fwupd/issues/209
2017-08-30 10:54:29 +01:00
Mario Limonciello
f1cc61d2f0
trivial: dell: TPM switching blacklist->whitelist
...
It's been decided that TPM mode switching won't be supported
on any other new platforms. Instead of blacklisting the outliers
whitelist the (smaller) list of platforms that do support the
feature.
2017-08-29 16:37:14 -05:00
Mario Limonciello
257c14ebd1
dell: prefer to detect supported systems from OEM strings
...
This requires dmidecode 3.1 or later.
SMBIOS tables are not a reliable enough method on all systems.
2017-08-29 16:37:14 -05:00
Mario Limonciello
1790115c93
trivial: dell: don't advertise ---force in an error message
2017-08-29 15:23:00 -05:00
Yehezkel Bernat
f8e5622726
trivial: fix compilation warning
...
Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
2017-08-29 14:48:45 -05:00