proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-14 16:11:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dell: catch invalid dock component requests

Browse Source 
Test if g_strrstr returns NULL, as this means the string was
modified and other requests predicated on this will fail miserably.
This commit is contained in:
Mario Limonciello 2017-11-06 16:39:30 -05:00 committed by Mario Limonciello
parent 3164784d9e
commit 7f3bfc9d99
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/dell/fu-plugin-dell.c
View File

@ -439,9 +439,14 @@ fu_plugin_dell_device_added_cb (GUsbContext *ctx,
dock_info->components[i].description,
dock_info->components[i].fw_version);
query_str = g_strrstr (dock_info->components[i].description,
"Query ") + 6;
if (!fu_plugin_dell_match_dock_component (query_str, &guid_raw,
&component_name)) {
"Query ");
if (query_str == NULL) {
g_debug ("Invalid dock component request");
return;
}
if (!fu_plugin_dell_match_dock_component (query_str + 6,
&guid_raw,
&component_name)) {
g_debug ("Unable to match dock component %s",
query_str);
return;