Richard Hughes
df9cc282ec
trivial: Only build the synapticsmst if HAVE_SYNAPTICS is set
2017-01-20 12:52:58 +00:00
Mario Limonciello
72f905d846
trivial: dell: fix test suite
...
Commit cd87fca
2017-01-19 14:16:23 -06:00
Richard Hughes
67a756c93f
synapticsmst: Refactor away the global state
...
The synapticsmst-common.c file had some global state so that cascade devices
could use the device fd. This made the control flow error prone, and it meant
that the fd could be leaked trivially on any error path.
Moving the fd ownership to the device is the logical place for the control, and
means we can create "connections" to access the main device and the cascade
devices.
This fixes the warnings detected by Coverity.
2017-01-19 13:41:04 +00:00
Richard Hughes
fffa21639b
trivial: unindent a code block
2017-01-19 08:51:16 +00:00
Richard Hughes
d99282f2ca
trivial: Fix an anti-pattern when returning error strings
2017-01-19 08:43:06 +00:00
Richard Hughes
2ef5ae0536
trivial: dell: Fix some intenting that was making coverity unhappy
2017-01-18 08:32:45 +00:00
Mario Limonciello
836ff015b3
trivial: synaptics: on new systems show unknown rather than failing
2017-01-17 16:08:04 -06:00
Mario Limonciello
7d5003e643
trivial: synaptics: don't fail on systems with less DP aux nodes
2017-01-17 13:23:46 -06:00
Mario Limonciello
548c6901c4
trivial: synaptics: add missing ID string for Rugged platforms
2017-01-17 12:13:59 -06:00
Mario Limonciello
0ed79d5455
trivial: synaptics: log invalid board IDs
2017-01-17 12:02:15 -06:00
Mario Limonciello
cd87fcae5a
trivial: dell: don't disable plugin if UEFI capsule isn't supported
...
It now supports enabling things for other plugins too, so rather
mark any devices created by Dell as only readable, not flashable
when UEFI capsule is off.
2017-01-17 11:49:33 -06:00
Mario Limonciello
908b17e1fb
trivial: dell: Don't output error domain twice
2017-01-17 11:38:34 -06:00
Mario Limonciello
f48a93546e
trivial: dell: only enable coldplug delay when needed
...
The coldplug delay that Dell uses is only needed for the thunderbolt
and synaptics MST plugins.
2017-01-17 11:35:20 -06:00
Richard Hughes
31fd185ecf
trivial: Fix make distcheck
2017-01-17 15:44:52 +00:00
Richard Hughes
6a9c91a083
trivial: Fix a trivial warning in the altos plugin
2017-01-17 15:37:08 +00:00
Richard Hughes
8dafc604e0
trivial: Fix up the typedef'd enum style
2017-01-17 14:15:00 +00:00
Richard Hughes
2153cd0f89
trivial: Use guint8 rather than guchar
...
Although it's probably the same, this matches the other plugins.
2017-01-17 14:10:12 +00:00
Richard Hughes
26aade02d2
trivial: Don't use caps in variable names
2017-01-17 13:21:14 +00:00
Pei-Chen Huang
9225270421
trivial: fix synaptics device scan cascade function
2017-01-17 06:23:45 -06:00
Richard Hughes
3d8d48c896
trivial: Remove boilerplate gtk-doc from plugin
2017-01-17 11:17:29 +00:00
Richard Hughes
0c91cb0a94
trivial: Don't output the error domain twice
2017-01-17 11:17:29 +00:00
Richard Hughes
ae040f77b8
trivial: Fix some indenting in synapticsmst
2017-01-17 11:17:29 +00:00
Richard Hughes
94ce14f317
trivial: Use rc for return codes
...
The variable ret is normally reserved for boolean values.
2017-01-17 08:58:40 +00:00
Richard Hughes
1967c6c9ac
trivial: Fix up some missing return value assignments
...
Spotted by coverity.
2017-01-17 08:54:34 +00:00
Richard Hughes
db0a3cb37f
trivial: Fix up some indent issues spotted by coverity
2017-01-17 08:54:03 +00:00
Richard Hughes
999f66ab13
trivial: Actually set the Unifying device name
2017-01-16 22:00:40 +00:00
Mario Limonciello
f53e4a2d4b
trivial: synapticsmst: only enable plugin if kernel support is present
2017-01-16 15:37:11 -06:00
Mario Limonciello
8eaf6dbcd6
trivial: synapticsmst: don't proceed if device open fails
2017-01-16 15:14:47 -06:00
Pei-Chen Huang
abac1640a5
synapticsmst: Add cascade support
2017-01-16 11:23:43 -06:00
Mario Limonciello
24afb470f2
Introduce plugin for Synaptics MST hubs
2017-01-16 11:23:43 -06:00
Richard Hughes
e3c8832dd0
trivial: Fix a critical warning when removing thunderbolt devices in safe mode
2017-01-11 21:51:21 +00:00
Mario Limonciello
038d386a82
dell: introduce a standalone (noinst) tool to force mode flashes
2017-01-11 15:35:55 -06:00
Richard Hughes
2520b7d1ed
trivial: Add some debugging in the thunderbolt plugin
2017-01-11 17:24:20 +00:00
Richard Hughes
26adb3c819
trivial: Fix a crash when flashing a thunderbolt controller in safe mode
2017-01-11 17:21:10 +00:00
Mario Limonciello
0d92e865aa
trivial: thunderbolt: don't allocate new plugin data on rescan
2017-01-10 19:55:12 -06:00
Mario Limonciello
9df75f7206
trivial: dell: move coldplug delay setting to startup()
2017-01-10 17:13:08 -06:00
Richard Hughes
cd35e3c242
trivial: Fix a compile warning when doing a unifying control transfer
2017-01-10 22:10:50 +00:00
Richard Hughes
04ec912b19
trivial: Fix some colorhug function name prefixes
2017-01-10 22:10:50 +00:00
Richard Hughes
932eb397d2
trivial: Fix 'make distcheck'
2017-01-10 22:10:50 +00:00
Mario Limonciello
592ab30b3c
trivial: dell: update_prepare/update_cleanup on only certain plugins
2017-01-10 15:39:25 -06:00
Richard Hughes
23b9c9d78d
trivial: Use the per-plugin cache for the runtime device
...
There is no point having two hash tables doing the same thing...
2017-01-10 16:09:38 +00:00
Richard Hughes
0de35b058d
unifying: Subclass FuDevice like the altos plugin
2017-01-10 16:09:32 +00:00
Richard Hughes
a4e44ce39b
altos: Set the flags in the init_real so they work for the cmdline tool
2017-01-10 16:09:32 +00:00
Richard Hughes
b721d4326f
ebitdo: Subclass FuDevice like the altos plugin
...
This makes things much simpler.
2017-01-10 14:02:16 +00:00
Richard Hughes
dc390e3a68
trivial: Set up two flags not set by cfmakeraw()
2017-01-10 12:49:52 +00:00
Richard Hughes
7a44ff9748
altos: Add error checking when using termios
2017-01-10 12:48:08 +00:00
Richard Hughes
b082903c5f
Add fu_plugin_set_coldplug_delay() to allow hardware to initialize if required
2017-01-10 09:27:08 +00:00
Richard Hughes
10ec93b187
Revert "thunderbolt: add some guards around empty arrays"
...
This reverts commit 5f1c991c40
2017-01-09 21:34:43 +00:00
Richard Hughes
efa55b83a7
dell: Fix possible linker problem
...
The linker does not know which public symbol to call if a plugin calls it's own
symbol. Without this change one plugin could call into another plugin with the
wrong GsPluginData set.
2017-01-09 21:32:44 +00:00
Richard Hughes
2b464378ea
trivial: Add flags to fu_device_altos_write_firmware()
2017-01-09 21:25:50 +00:00
Mario Limonciello
2bcc151619
dell: Adjust the coldplug preparation and cleanup sequence
...
Unfortunately no indication is made that a GPIO change is
done so some time needs to be left to make sure this happened.
2017-01-09 13:31:35 -06:00
Mario Limonciello
5f1c991c40
thunderbolt: add some guards around empty arrays
...
Depending upon the call order and devices coming or going these
may or may not have anything actually contained which will cause
segfaults otherwise.
2017-01-09 11:11:19 -06:00
Richard Hughes
05133fefb7
Add support for flashing the ChaosKey
2017-01-09 12:21:35 +00:00
Richard Hughes
4ff3169556
thunderbolt: Detecting new devices and add an actual device to the daemon
...
Also, add an untested update implementation.
Based on a patch by Eric Rubin-smith <ericx.rubin-smith@intel.com>, many thanks.
2017-01-08 16:14:35 +00:00
Richard Hughes
1d511fafa6
trivial: Fix a uninitialized value in the dell plugin
...
Spotted using clang.
2017-01-07 22:14:28 +00:00
Richard Hughes
c7ea2a2369
trivial: Fix up two compile warnings
2017-01-07 22:10:14 +00:00
Richard Hughes
46487c944a
Add the ability to run a prepare->exec->cleanup on coldplug
...
The idea here is that plugins can 'wake up' hardware in prepare, and put it
back into powersaving mode when doing cleanup.
2017-01-07 21:26:36 +00:00
Richard Hughes
57d8bf6590
trivial: Fix a compile warning in the dell plugin
2017-01-07 21:15:46 +00:00
Mario Limonciello
5723c2f643
dell: Add coldplug methods to let other plugins turn on TBT/GPIO
...
Remove the dummy devices created for NVM and MST, these will
be created by other plugins. Other plugins will however
be using the Dell methods to enable these devices.
2017-01-06 15:25:57 -06:00
Mario Limonciello
ddeb0297bf
trivial: dell: remove unnecessary usb_ctx after moving to plugins
2017-01-06 12:03:21 -06:00
Mario Limonciello
49c96b8941
trivial: dell: remove unnecessary include
2017-01-06 12:03:21 -06:00
Richard Hughes
7ceb318a27
Add fwupd_result_get_device_version_bootloader()
...
This functionality is required so that AppStream metadata can check the fwupd
version, the firmware version, bootloader version or a combination of all three.
2016-12-23 11:21:22 +00:00
Richard Hughes
0075a98b51
unifying: Use the actual bootloader VID/PIDs when in firmware mode
2016-12-16 21:24:55 +00:00
Richard Hughes
04042a10e8
trivial: Fix a tiny memory leak in the Udev plugin
...
Also, fix some method prefixes to match the plugin name.
2016-12-16 14:03:08 +00:00
Richard Hughes
a59777ad8d
Add initial skeleton for Intel Thunderbolt support
2016-12-16 12:41:57 +00:00
Richard Hughes
598a40d746
trivial: Use a delay when adding Udev devices
...
There might be a better plugin to claim these than the generic fallback.
2016-12-16 12:41:57 +00:00
Richard Hughes
ae3d65f60b
Move the device add delay to shared code
...
This allows us to reuse the logic in other plugins.
2016-12-16 12:41:57 +00:00
Richard Hughes
74702297b2
Move the Option ROM parsing to the Udev plugin
2016-12-15 17:09:38 +00:00
Mario Limonciello
3b09e323c8
trivial: whitespace fixes in dell plugin
2016-12-15 10:30:41 -06:00
Mario Limonciello
9bb952ac7e
dell: add a new method for forcing a controller to flash mode
...
This method will be used in conjunction with other new plugins
in the future that will perform online flashes.
2016-12-15 10:30:37 -06:00
Richard Hughes
0c7c4e4406
trivial: Use the HIDPP constants from libratbag
2016-12-15 16:26:30 +00:00
Richard Hughes
561c457149
trivial: Use unique profiling IDs in plugins
2016-12-15 12:55:21 +00:00
Richard Hughes
c591460ff8
trivial: Fix a warning when compiling the unifying plugin
2016-12-14 10:52:44 +00:00
Mario Limonciello
02ccecb2be
fix dfu plugin loading
...
failed to open plugin
/usr/lib/x86_64-linux-gnu/fwupd-plugins-2/libfu_plugin_dfu.so:
failed to open plugin:
/usr/lib/x86_64-linux-gnu/fwupd-plugins-2/libfu_plugin_dfu.so:
undefined symbol: dfu_device_upload
2016-12-13 13:19:55 -06:00
Mario Limonciello
f074b0d367
Fix udev plugin loading
...
failed to open plugin /usr/lib/x86_64-linux-gnu/fwupd-plugins-2/libfu_plugin_udev.so:
failed to open plugin: /usr/lib/x86_64-linux-gnu/fwupd-plugins-2/libfu_plugin_udev.so:
undefined symbol: g_udev_device_get_property
2016-12-13 13:19:51 -06:00
Mario Limonciello
e781bb9b64
trivial: fix cosmetic fallout from provider -> plugin
...
some code (such as libfwupd) still internally refers to provider,
but this will need to be more carefully massaged
2016-12-13 12:25:09 -06:00
Mario Limonciello
6a1cbc61b2
trivial: correct raspberry pi error message
2016-12-13 12:03:49 -06:00
Richard Hughes
4232185bec
trivial: Remove some false-positive messages when using clang
2016-12-13 16:01:52 +00:00
Richard Hughes
ee54d32f4d
trivial: Fix a Coverity false positive
2016-12-12 17:02:10 +00:00
Richard Hughes
59a9344c1e
Move the UPower functionality to a plugin
2016-12-12 16:28:16 +00:00
Richard Hughes
864363e139
Add support for Logitech Unifying devices
...
If you do not have Unifying hardware you can emulate writing firmware using:
$ fu-unifying-tool write file.hex -v --emulate=bootloader-nordic
2016-12-12 15:36:53 +00:00
Richard Hughes
cff38bcb3a
Convert the providers to plugins to simplify code and for future features
...
This is a large commit that removes all the providers and turns them into
plugins. I think having both providers _and_ plugins was super confusing.
Plugins are loaded at runtime so you could in theory develop a new plugin
without putting it in the fwupd source tree, although there are no installed
headers or PC files as I'm not sure it's a good idea at this stage.
This commit moves all the per-provider docs, tests, notes, debug dumps and test
data to plugin-specific directories -- these also allows the plugin author to
"own" more of the source tree so we don't enforce fu- prefixes and the style
guide everywhere.
This allows us to run the same action on all the plugins in the future, so we
could have a prepare(FuPlugin, FuDevice) and cleanup(FuPlugin, FuDevice) run
on *all* plugins, so doing an update using one plugin would allow us to work
around hardware quirks in other plugins.
If I've broken your out-of-tree provider it's trivial to port to the new API
with sed and a fixed up build file. If you need help please let me know.
2016-12-12 12:31:23 +00:00
Richard Hughes
319a6bab12
Move the plugins into plugin-specific directories
...
This will allow us to add further documentation here in the future.
2016-12-12 11:52:03 +00:00
