proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2026-02-01 15:37:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: Remove some false-positive messages when using clang

Browse Source
This commit is contained in:
Richard Hughes 2016-12-13 16:01:52 +00:00
parent ee54d32f4d
commit 4232185bec
8 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
plugins/dfu/fu-plugin-dfu.c
View File

@ -131,6 +131,7 @@ fu_plugin_dfu_device_added_cb (DfuContext *ctx,
platform_id,
dfu_device_get_runtime_vid (device),
dfu_device_get_runtime_pid (device));
g_assert (ptask != NULL);
/* ignore defective runtimes */
if (dfu_device_get_mode (device) == DFU_MODE_RUNTIME &&

1
plugins/ebitdo/fu-plugin-ebitdo.c
View File

@ -50,6 +50,7 @@ fu_plugin_ebitdo_device_added (FuPlugin *plugin,
ptask = as_profile_start (profile, "FuPlugin:added{%04x:%04x}",
g_usb_device_get_vid (usb_device),
g_usb_device_get_pid (usb_device));
g_assert (ptask != NULL);
/* get version */
platform_id = g_usb_device_get_platform_id (usb_device);

1
plugins/steelseries/fu-plugin-steelseries.c
View File

@ -56,6 +56,7 @@ fu_plugin_steelseries_device_added_cb (GUsbContext *ctx,
ptask = as_profile_start (profile, "FuPlugin:added{%04x:%04x}",
g_usb_device_get_vid (usb_device),
g_usb_device_get_pid (usb_device));
g_assert (ptask != NULL);
/* is already in database */
platform_id = g_usb_device_get_platform_id (usb_device);

2
plugins/udev/fu-plugin-udev.c
View File

@ -130,6 +130,7 @@ fu_plugin_client_add (FuPlugin *plugin, GUdevDevice *device)
/* get data */
ptask = as_profile_start (profile, "FuPlugin:client-add{%s}", guid);
g_assert (ptask != NULL);
g_debug ("adding udev device: %s", g_udev_device_get_sysfs_path (device));
/* is already in database */
@ -246,6 +247,7 @@ fu_plugin_coldplug (FuPlugin *plugin, GError **error)
for (guint i = 0; devclass[i] != NULL; i++) {
g_autoptr(AsProfileTask) ptask = NULL;
ptask = as_profile_start (profile, "FuPlugin:coldplug{%s}", devclass[i]);
g_assert (ptask != NULL);
devices = g_udev_client_query_by_subsystem (data->gudev_client,
devclass[i]);
for (GList *l = devices; l != NULL; l = l->next) {

1
plugins/unifying/fu-plugin-unifying.c
View File

@ -47,6 +47,7 @@ fu_plugin_unifying_device_added (FuPlugin *plugin,
ptask = as_profile_start (profile, "FuPlugin:added{%04x:%04x}",
g_usb_device_get_vid (usb_device),
g_usb_device_get_pid (usb_device));
g_assert (ptask != NULL);
/* get version */
platform_id = g_usb_device_get_platform_id (usb_device);

2
plugins/usb/fu-plugin-usb.c
View File

@ -46,6 +46,7 @@ fu_plugin_usb_device_added (FuPlugin *plugin, GUsbDevice *device)
ptask = as_profile_start (profile, "FuPlugin:added{%04x:%04x}",
g_usb_device_get_vid (device),
g_usb_device_get_pid (device));
g_assert (ptask != NULL);
/* is already in database */
platform_id = g_usb_device_get_platform_id (device);
@ -70,6 +71,7 @@ fu_plugin_usb_device_added (FuPlugin *plugin, GUsbDevice *device)
if (idx != 0x00) {
g_autoptr(AsProfileTask) ptask2 = NULL;
ptask2 = as_profile_start_literal (profile, "FuPlugin:get-string-desc");
g_assert (ptask2 != NULL);
product = g_usb_device_get_string_descriptor (device, idx, NULL);
}
if (product == NULL) {

4
src/fu-main.c
View File

@ -2033,6 +2033,7 @@ fu_main_plugins_setup (FuMainPrivate *priv)
g_autoptr(AsProfileTask) ptask = NULL;
ptask = as_profile_start_literal (priv->profile, "FuMain:setup");
g_assert (ptask != NULL);
for (guint i = 0; i < priv->plugins->len; i++) {
g_autoptr(GError) error = NULL;
g_autoptr(AsProfileTask) ptask2 = NULL;
@ -2040,6 +2041,7 @@ fu_main_plugins_setup (FuMainPrivate *priv)
ptask2 = as_profile_start (priv->profile,
"FuMain:setup{%s}",
fu_plugin_get_name (plugin));
g_assert (ptask2 != NULL);
if (!fu_plugin_runner_startup (plugin, &error)) {
fu_plugin_set_enabled (plugin, FALSE);
g_warning ("disabling plugin because: %s", error->message);
@ -2053,6 +2055,7 @@ fu_main_plugins_coldplug (FuMainPrivate *priv)
g_autoptr(AsProfileTask) ptask = NULL;
ptask = as_profile_start_literal (priv->profile, "FuMain:coldplug");
g_assert (ptask != NULL);
for (guint i = 0; i < priv->plugins->len; i++) {
g_autoptr(GError) error = NULL;
g_autoptr(AsProfileTask) ptask2 = NULL;
@ -2060,6 +2063,7 @@ fu_main_plugins_coldplug (FuMainPrivate *priv)
ptask2 = as_profile_start (priv->profile,
"FuMain:coldplug{%s}",
fu_plugin_get_name (plugin));
g_assert (ptask2 != NULL);
if (!fu_plugin_runner_coldplug (plugin, &error)) {
fu_plugin_set_enabled (plugin, FALSE);
g_warning ("disabling plugin because: %s", error->message);

1
src/fu-rom.c
View File

@ -741,6 +741,7 @@ fu_rom_load_file (FuRom *rom, GFile *file, FuRomLoadFlags flags,
/* open file */
ptask = as_profile_start_literal (profile, "FuRom:reading-data");
g_assert (ptask != NULL);
priv->stream = G_INPUT_STREAM (g_file_read (file, cancellable, &error_local));
if (priv->stream == NULL) {
g_set_error_literal (error,