proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-27 11:09:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

wacom-raw: Fix a Coverity false positive

Browse Source 
Technically this is an OOB write, but we're deliberately writing into
the next section of the FuWacomRawRequest structure.

Be explicit to avoid Coverity warnings.
This commit is contained in:
Richard Hughes 2022-04-13 12:01:17 +01:00
parent a7149a4dac
commit d0c8514c52
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/wacom-raw/fu-wacom-emr-device.c
View File

@ -177,9 +177,9 @@ fu_wacom_emr_device_write_block(FuWacomEmrDevice *self,
memcpy(&req.data, data, datasz); memcpy(&req.data, data, datasz);
/* cmd and data checksums */ /* cmd and data checksums */
req.data[blocksz + 0] = req.data_unused[0] =
fu_wacom_emr_device_calc_checksum(0x05 + 0x00 + 0x4c + 0x00, (const guint8 *)&req, 8); fu_wacom_emr_device_calc_checksum(0x05 + 0x00 + 0x4c + 0x00, (const guint8 *)&req, 8);
req.data[blocksz + 1] = fu_wacom_emr_device_calc_checksum(0x00, data, datasz); req.data_unused[1] = fu_wacom_emr_device_calc_checksum(0x00, data, datasz);
if (!fu_wacom_device_cmd(FU_WACOM_DEVICE(self), if (!fu_wacom_device_cmd(FU_WACOM_DEVICE(self),
&req, &req,
&rsp, &rsp,