From d0c8514c528276b482a89d8f7bf40d07e58f63af Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Wed, 13 Apr 2022 12:01:17 +0100 Subject: [PATCH] wacom-raw: Fix a Coverity false positive Technically this is an OOB write, but we're deliberately writing into the next section of the FuWacomRawRequest structure. Be explicit to avoid Coverity warnings. --- plugins/wacom-raw/fu-wacom-emr-device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/wacom-raw/fu-wacom-emr-device.c b/plugins/wacom-raw/fu-wacom-emr-device.c index f8cd16381..7d3a822e6 100644 --- a/plugins/wacom-raw/fu-wacom-emr-device.c +++ b/plugins/wacom-raw/fu-wacom-emr-device.c @@ -177,9 +177,9 @@ fu_wacom_emr_device_write_block(FuWacomEmrDevice *self, memcpy(&req.data, data, datasz); /* cmd and data checksums */ - req.data[blocksz + 0] = + req.data_unused[0] = fu_wacom_emr_device_calc_checksum(0x05 + 0x00 + 0x4c + 0x00, (const guint8 *)&req, 8); - req.data[blocksz + 1] = fu_wacom_emr_device_calc_checksum(0x00, data, datasz); + req.data_unused[1] = fu_wacom_emr_device_calc_checksum(0x00, data, datasz); if (!fu_wacom_device_cmd(FU_WACOM_DEVICE(self), &req, &rsp,