proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-05-15 20:31:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

plugins: Fix potential use of NULL pointer in fu_dell_dock_mst_write_register

Browse Source 
Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
This commit is contained in:
Francois Berder 2019-11-29 11:01:49 +00:00 committed by Mario Limonciello
parent 15daf69ad9
commit bb5385de76
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/dell-dock/fu-dell-dock-i2c-mst.c
View File

@ -185,12 +185,13 @@ fu_dell_dock_mst_write_register (FuDevice *symbiote,
GError **error) GError **error)
{ {
g_autofree guint8 *buffer = g_malloc0 (length + 4); g_autofree guint8 *buffer = g_malloc0 (length + 4);
memcpy (buffer, &address, 4);
memcpy (buffer + 4, data, length);
g_return_val_if_fail (symbiote != NULL, FALSE); g_return_val_if_fail (symbiote != NULL, FALSE);
g_return_val_if_fail (data != NULL, FALSE); g_return_val_if_fail (data != NULL, FALSE);
memcpy (buffer, &address, 4);
memcpy (buffer + 4, data, length);
/* write the offset we're querying */ /* write the offset we're querying */
return fu_dell_dock_hid_i2c_write (symbiote, buffer, length + 4, return fu_dell_dock_hid_i2c_write (symbiote, buffer, length + 4,
&mst_base_settings, error); &mst_base_settings, error);