From bb5385de76623c04bcc60e8fd7e516d581c7d25f Mon Sep 17 00:00:00 2001
From: Francois Berder <18538310+francois-berder@users.noreply.github.com>
Date: Fri, 29 Nov 2019 11:01:49 +0000
Subject: [PATCH] plugins: Fix potential use of NULL pointer in
 fu_dell_dock_mst_write_register

Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
---
 plugins/dell-dock/fu-dell-dock-i2c-mst.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/plugins/dell-dock/fu-dell-dock-i2c-mst.c b/plugins/dell-dock/fu-dell-dock-i2c-mst.c
index de729209e..072b3eec4 100644
--- a/plugins/dell-dock/fu-dell-dock-i2c-mst.c
+++ b/plugins/dell-dock/fu-dell-dock-i2c-mst.c
@@ -185,12 +185,13 @@ fu_dell_dock_mst_write_register (FuDevice *symbiote,
 				 GError **error)
 {
 	g_autofree guint8 *buffer = g_malloc0 (length + 4);
-	memcpy (buffer, &address, 4);
-	memcpy (buffer + 4, data, length);
 
 	g_return_val_if_fail (symbiote != NULL, FALSE);
 	g_return_val_if_fail (data != NULL, FALSE);
 
+	memcpy (buffer, &address, 4);
+	memcpy (buffer + 4, data, length);
+
 	/* write the offset we're querying */
 	return fu_dell_dock_hid_i2c_write (symbiote, buffer, length + 4,
 					   &mst_base_settings, error);