proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-05-29 18:43:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

synaptics-prometheus: Fix enumeration of the config child

Browse Source 
Do not manually call config setup before adding the parent.

The ->setup() action is called on children explicitly in fu_device_setup()
after the parent device has all the required properties.

Fixes https://github.com/fwupd/fwupd/issues/3364
This commit is contained in:
Richard Hughes 2021-06-15 17:18:55 +01:00 committed by Mario Limonciello
parent c0d0ce4e1a
commit 832231da9c
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/synaptics-prometheus/fu-synaprom-device.c
View File

@ -221,10 +221,6 @@ fu_synaprom_device_setup (FuDevice *device, GError **error)
!fu_device_has_flag (device, FWUPD_DEVICE_FLAG_IS_BOOTLOADER) && !fu_device_has_flag (device, FWUPD_DEVICE_FLAG_IS_BOOTLOADER) &&
pkt.security[1] & FU_SYNAPROM_SECURITY1_PROD_SENSOR) { pkt.security[1] & FU_SYNAPROM_SECURITY1_PROD_SENSOR) {
g_autoptr(FuSynapromConfig) cfg = fu_synaprom_config_new (self); g_autoptr(FuSynapromConfig) cfg = fu_synaprom_config_new (self);
if (!fu_device_setup (FU_DEVICE (cfg), error)) {
g_prefix_error (error, "failed to get config version: ");
return FALSE;
}
fu_device_add_child (FU_DEVICE (device), FU_DEVICE (cfg)); fu_device_add_child (FU_DEVICE (device), FU_DEVICE (cfg));
} }