From 832231da9c1c3cc8a40ea9145a1925f85f237a98 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Tue, 15 Jun 2021 17:18:55 +0100 Subject: [PATCH] synaptics-prometheus: Fix enumeration of the config child Do not manually call config setup before adding the parent. The ->setup() action is called on children explicitly in fu_device_setup() after the parent device has all the required properties. Fixes https://github.com/fwupd/fwupd/issues/3364 --- plugins/synaptics-prometheus/fu-synaprom-device.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/plugins/synaptics-prometheus/fu-synaprom-device.c b/plugins/synaptics-prometheus/fu-synaprom-device.c index 7d0d62ae9..85fed5e8d 100644 --- a/plugins/synaptics-prometheus/fu-synaprom-device.c +++ b/plugins/synaptics-prometheus/fu-synaprom-device.c @@ -221,10 +221,6 @@ fu_synaprom_device_setup (FuDevice *device, GError **error) !fu_device_has_flag (device, FWUPD_DEVICE_FLAG_IS_BOOTLOADER) && pkt.security[1] & FU_SYNAPROM_SECURITY1_PROD_SENSOR) { g_autoptr(FuSynapromConfig) cfg = fu_synaprom_config_new (self); - if (!fu_device_setup (FU_DEVICE (cfg), error)) { - g_prefix_error (error, "failed to get config version: "); - return FALSE; - } fu_device_add_child (FU_DEVICE (device), FU_DEVICE (cfg)); }