proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-04 11:31:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: uefi: Only set EFI variables on real systems

Browse Source 
Avoids copying from a NULL pointer.
Caught via clang static analysis
This commit is contained in:
Mario Limonciello 2018-09-20 23:08:50 -05:00 committed by Richard Hughes
parent 981ee65554
commit 6ed307c5fb
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/uefi/fu-uefi-device.c
View File

@ -339,16 +339,16 @@ fu_uefi_device_write_firmware (FuDevice *device, GBytes *fw, GError **error)
fu_uefi_prefix_efi_errors (error);
return FALSE;
}
}
/* save this header and body to the hardware */
datasz = sizeof(info) + dp_bufsz;
data = g_malloc0 (datasz);
memcpy (data, &info, sizeof(info));
memcpy (data + sizeof(info), dp_buf, dp_bufsz);
if (!fu_uefi_device_set_efivar (self, data, datasz, error)) {
fu_uefi_prefix_efi_errors (error);
return FALSE;
/* save this header and body to the hardware */
datasz = sizeof(info) + dp_bufsz;
data = g_malloc0 (datasz);
memcpy (data, &info, sizeof(info));
memcpy (data + sizeof(info), dp_buf, dp_bufsz);
if (!fu_uefi_device_set_efivar (self, data, datasz, error)) {
fu_uefi_prefix_efi_errors (error);
return FALSE;
}
}
/* update the firmware before the bootloader runs */