From 6ed307c5fb99dbc1d19a5bf024992868429f0070 Mon Sep 17 00:00:00 2001 From: Mario Limonciello Date: Thu, 20 Sep 2018 23:08:50 -0500 Subject: [PATCH] trivial: uefi: Only set EFI variables on real systems Avoids copying from a NULL pointer. Caught via clang static analysis --- plugins/uefi/fu-uefi-device.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/plugins/uefi/fu-uefi-device.c b/plugins/uefi/fu-uefi-device.c index f8b7097ce..2cf3933ba 100644 --- a/plugins/uefi/fu-uefi-device.c +++ b/plugins/uefi/fu-uefi-device.c @@ -339,16 +339,16 @@ fu_uefi_device_write_firmware (FuDevice *device, GBytes *fw, GError **error) fu_uefi_prefix_efi_errors (error); return FALSE; } - } - /* save this header and body to the hardware */ - datasz = sizeof(info) + dp_bufsz; - data = g_malloc0 (datasz); - memcpy (data, &info, sizeof(info)); - memcpy (data + sizeof(info), dp_buf, dp_bufsz); - if (!fu_uefi_device_set_efivar (self, data, datasz, error)) { - fu_uefi_prefix_efi_errors (error); - return FALSE; + /* save this header and body to the hardware */ + datasz = sizeof(info) + dp_bufsz; + data = g_malloc0 (datasz); + memcpy (data, &info, sizeof(info)); + memcpy (data + sizeof(info), dp_buf, dp_bufsz); + if (!fu_uefi_device_set_efivar (self, data, datasz, error)) { + fu_uefi_prefix_efi_errors (error); + return FALSE; + } } /* update the firmware before the bootloader runs */