proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-04 01:20:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: fu-engine: correct a logic error in the daemon for thunderbolt

Browse Source 
WD19TB uses skip-restart in some cases, but not all.
The matrix of cases is enumerated in 834b28009d

Unfortunately in the most common case now - new kernel and new daemon
`skip-restart` *isn't* used.  The device should be left in a `needs-activation`
state though.

Use this to skip the trigger of failed upload report.

Fixes: #2731
This commit is contained in:
Mario Limonciello 2021-01-05 13:15:42 -06:00 committed by Richard Hughes
parent f1c79a8eae
commit 3165e94f7d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/fu-engine.c
View File

@ -2237,7 +2237,7 @@ fu_engine_install_release (FuEngine *self,
if (version_rel != NULL &&
fu_common_vercmp_full (version_orig, version_rel, fmt) != 0 &&
fu_common_vercmp_full (version_orig, fu_device_get_version (device), fmt) == 0 &&
!fu_device_has_flag (device, FWUPD_DEVICE_FLAG_SKIPS_RESTART)) {
!fu_device_has_flag (device, FWUPD_DEVICE_FLAG_NEEDS_ACTIVATION)) {
g_autofree gchar *str = NULL;
fu_device_set_update_state (device, FWUPD_UPDATE_STATE_FAILED);
str = g_strdup_printf ("device version not updated on success, %s != %s",