From 3165e94f7da67b3c3995c72e5d9a809976e4c9e7 Mon Sep 17 00:00:00 2001 From: Mario Limonciello Date: Tue, 5 Jan 2021 13:15:42 -0600 Subject: [PATCH] trivial: fu-engine: correct a logic error in the daemon for thunderbolt WD19TB uses skip-restart in some cases, but not all. The matrix of cases is enumerated in 834b28009d7e8fab9d37621456973a51a521c284 Unfortunately in the most common case now - new kernel and new daemon `skip-restart` *isn't* used. The device should be left in a `needs-activation` state though. Use this to skip the trigger of failed upload report. Fixes: #2731 --- src/fu-engine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fu-engine.c b/src/fu-engine.c index c1a4764ad..43653517a 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -2237,7 +2237,7 @@ fu_engine_install_release (FuEngine *self, if (version_rel != NULL && fu_common_vercmp_full (version_orig, version_rel, fmt) != 0 && fu_common_vercmp_full (version_orig, fu_device_get_version (device), fmt) == 0 && - !fu_device_has_flag (device, FWUPD_DEVICE_FLAG_SKIPS_RESTART)) { + !fu_device_has_flag (device, FWUPD_DEVICE_FLAG_NEEDS_ACTIVATION)) { g_autofree gchar *str = NULL; fu_device_set_update_state (device, FWUPD_UPDATE_STATE_FAILED); str = g_strdup_printf ("device version not updated on success, %s != %s",