4 Commits

Author	SHA1	Message	Date
Ruben Bridgewater	f8763bb077	benchmark,doc,lib,test: capitalize comments ... PR-URL: https://github.com/nodejs/node/pull/26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	2019-03-10 00:44:40 +01:00
cjihrig	907941d48e	http: validate timeout in ClientRequest() ... Validate the timeout option in the ClientRequest() constructor to prevent asynchronously thrown validation errors. PR-URL: https://github.com/nodejs/node/pull/26214 Fixes: https://github.com/nodejs/node/issues/26143 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	2019-02-26 16:12:54 -05:00
Gibson Fahnestock	7a0e462f9f	test: use eslint to fix var->const/let ... Manually fix issues that eslint --fix couldn't do automatically. PR-URL: https://github.com/nodejs/node/pull/10685 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>	2017-01-11 11:43:52 +00:00
Rene Weber	c9b59e8387	http: socket connection timeout for http request ... This allows passing the socket connection timeout to http#request such that it will be set before the socket is connecting PR-URL: https://github.com/nodejs/node/pull/8101 Fixes: https://github.com/nodejs/node/issues/7580 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>	2016-09-26 13:33:52 +03:00