jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-08 05:00:21 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity
28,253 Commits 67 Branches 878 Tags 2.1 GiB
1a25e901b7
Commit Graph

3 Commits

Author SHA1 Message Date
Luigi Pinca
b8d9d4ac68 test: refactor test-http-agent-timeout-option 
There is no need to establish a TCP connection. It is sufficient to
test that the listener that forwards the `'timeout'` event from the
socket to the `ClientRequest` instance is added to the socket.

PR-URL: https://github.com/nodejs/node/pull/25886
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-02-07 07:38:48 +01:00
Luigi Pinca
988482e234 test: refactor test-http-agent-timeout-option 
Fix flakyness caused by usage of a non-routable IP address.

Refs: https://github.com/nodejs/node/pull/25488#issuecomment-459385146

PR-URL: https://github.com/nodejs/node/pull/25854
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2019-02-01 22:44:33 -08:00
Luigi Pinca
4b6e4c1eb1 http: make timeout event work with agent timeout 
The `'timeout'` event is currently not emitted on the `ClientRequest`
instance when the socket timeout expires if only the `timeout` option
of the agent is set. This happens because, under these circumstances,
`listenSocketTimeout()` is not called.

This commit fixes the issue by calling it also when only the agent
`timeout` option is set.

PR-URL: https://github.com/nodejs/node/pull/25488
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-01-31 11:51:25 +01:00