3 Commits

Author	SHA1	Message	Date
ZYSzys	dcc5e51e1c	tools: force common be required before any other modules ... PR-URL: https://github.com/nodejs/node/pull/27650 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	2019-05-13 19:39:34 +08:00
Rich Trott	3ccb900e0c	test: add missing tmpdir.refresh() in recently-added test ... Without `tmpdir.refresh()`, the test fails in some situations. This was missed because using `test.py` will almost always result in a leftover tmpdir lying around that makes the `refresh()` not needed. Refs: https://github.com/nodejs/node/pull/24913#issuecomment-447982921 PR-URL: https://github.com/nodejs/node/pull/25098 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>	2018-12-18 07:13:32 -08:00
Eduard Bondarenko	20770073ba	child_process: spawn ignores options in case args is undefined ... spawn method ignores 3-d argument 'options' in case the second one 'args' equals to 'undefined'. Fixes: https://github.com/nodejs/node/issues/24912 PR-URL: https://github.com/nodejs/node/pull/24913 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>	2018-12-16 07:22:45 -08:00