jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-08 06:36:38 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity
28,253 Commits 67 Branches 878 Tags 2.1 GiB
1a25e901b7
Commit Graph

3 Commits

Author SHA1 Message Date
Octavian Soldea
1ee47d550c n-api: refactoring napi_create_function testing 
This is a refactoring of https://github.com/nodejs/node/pull/26998
following https://github.com/nodejs/node/pull/28505.

The functions `add_last_status()` and `add_returned_status()` are now
reused, see also https://github.com/nodejs/node/pull/28848.

PR-URL: https://github.com/nodejs/node/pull/28894
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2019-07-31 23:19:41 -07:00
Octavian Soldea
06c803d9b9 test: pass null params to napi_create_function() 
Each one of the following arguments is checked:
  napi_env env,
  const char* utf8name,
  napi_callback cb,
  napi_value* result.

PR-URL: https://github.com/nodejs/node/pull/26998
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
 2019-04-10 16:35:22 -07:00
Gabriel Schulhof
938e11882b test: partition N-API tests 
Partition test/addons-napi into test/js-native-api and test/node-api to
isolate the Node.js-agnostic portion of the N-API tests from the
Node.js-specific portion.

PR-URL: https://github.com/nodejs/node/pull/24557
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2018-12-04 13:58:17 -08:00