Go to file
Christian Ebner 4e1676a432 api: datastore: fix cache store creation when reusing s3 backend
Commit 3cc3c10d ("datastore: mark store as in-use by setting marker
on s3 backend") introduced the marker object on datastores used by
another instance. The check was however flawed as it made the local
chunk store creation dependent on the s3 client instantiation.

Therefore, instead factor out the DatastoreBackendType determination,
use that for the check and never assume the local cache store to
be pre-existing.

Also, since contents from the s3 store are refreshed anyway, local
contents in the cache store will be removed, except chunks which
are now cleaned up on create.

Fixes: 3cc3c10d ("datastore: mark store as in-use by setting marker on s3 backend")
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Link: https://lore.proxmox.com/20250724080233.282783-1-c.ebner@proxmox.com
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2025-07-24 11:25:57 +02:00
.cargo cargo config: add debug=true 2024-06-25 14:21:58 +02:00
debian d/postinst: fix-up file name for beta sources file 2025-07-24 11:21:36 +02:00
docs avoid leaking internal s3client struct name to the outside, favor s3-endpoint 2025-07-23 21:29:02 +02:00
etc fixup Makefile and lintian-overrides for deb822 format sources file 2025-07-15 22:34:35 +02:00
examples api: backup: add no-cache flag to bypass local datastore cache 2025-07-22 21:43:43 +02:00
pbs-buildcfg use new apt/apt-api-types crate 2024-07-08 15:28:59 +02:00
pbs-client client: adapt pbs client to also handle HttpOnly flows correctly 2025-07-23 20:21:09 +02:00
pbs-config avoid leaking internal s3client struct name to the outside, favor s3-endpoint 2025-07-23 21:29:02 +02:00
pbs-datastore config: s3: adapt to new config struct layouts 2025-07-22 21:43:43 +02:00
pbs-fuse-loop fuse-loop: remove lazy_static dependency 2024-08-14 12:08:01 +02:00
pbs-key-config move pbs_config::key_config to pbs-key-config 2022-12-12 14:19:52 +01:00
pbs-pxar-fuse clippy: elide more lifetimes 2024-12-02 11:34:05 +01:00
pbs-tape tape: skip setting encryption if we can't and don't want to 2025-07-22 19:16:44 +02:00
pbs-tools tools: async lru cache: implement insert, remove and contains methods 2025-07-22 21:43:43 +02:00
proxmox-backup-banner update proxmox-backup-banner to nix 0.29 2025-06-16 13:59:37 +02:00
proxmox-backup-client api: backup: add no-cache flag to bypass local datastore cache 2025-07-22 21:43:43 +02:00
proxmox-file-restore proxmox-file-restore: allocate at least 256MB of RAM for the restore VM 2025-07-15 22:17:26 +02:00
proxmox-restore-daemon update proxmox-restore-daemon to nix 0.29 and proxmox-base64 2025-06-16 13:59:37 +02:00
pxar-bin log: use new builder initializer 2025-03-19 12:02:48 +01:00
src api: datastore: fix cache store creation when reusing s3 backend 2025-07-24 11:25:57 +02:00
templates notifications: remove HTML template for test notification 2025-04-02 14:42:42 +02:00
tests client/server: use dedicated api type for all archive names 2024-11-22 13:47:05 +01:00
www ui: add beta text with link to bugtracker 2025-07-24 00:45:42 +02:00
zsh-completions zsh: fix completions 2021-09-03 10:29:48 +02:00
.gitignore gitignore: generally ignore generated systemd service files 2024-03-08 08:00:30 +01:00
Cargo.toml bump version to 4.0.5-1 2025-07-23 21:53:53 +02:00
defines.mk docs: add datastore.cfg.5 man page 2021-02-10 11:05:02 +01:00
Makefile build: Adapt from pbs2to3 to pbs3to4 2025-07-15 22:20:03 +02:00
README.rst readme: clarify when one needs to adjust the rustup config 2024-12-16 13:54:59 +01:00
rustfmt.toml bump edition in rustfmt.toml 2022-10-13 15:01:11 +02:00
TODO.rst tape: add/use rust scsi changer implementation using libsgutil2 2021-01-25 13:14:07 +01:00

Build & Release Notes
*********************

``rustup`` Toolchain
====================

We normally want to build with the ``rustc`` Debian package (see below). If you
still want to use ``rustup`` for other reasons (e.g. to easily switch between
the official stable, beta, and nightly compilers), you should set the following
``rustup`` configuration to use the Debian-provided ``rustc`` compiler
by default:

    # rustup toolchain link system /usr
    # rustup default system


Versioning of proxmox helper crates
===================================

To use current git master code of the proxmox* helper crates, add::

   git = "git://git.proxmox.com/git/proxmox"

or::

   path = "../proxmox/proxmox"

to the proxmox dependency, and update the version to reflect the current,
pre-release version number (e.g., "0.1.1-dev.1" instead of "0.1.0").


Local cargo config
==================

This repository ships with a ``.cargo/config.toml`` that replaces the crates.io
registry with packaged crates located in ``/usr/share/cargo/registry``.

A similar config is also applied building with dh_cargo. Cargo.lock needs to be
deleted when switching between packaged crates and crates.io, since the
checksums are not compatible.

To reference new dependencies (or updated versions) that are not yet packaged,
the dependency needs to point directly to a path or git source (e.g., see
example for proxmox crate above).


Build
=====
on Debian 12 Bookworm

Setup:
  1. # echo 'deb http://download.proxmox.com/debian/devel/ bookworm main' | sudo tee /etc/apt/sources.list.d/proxmox-devel.list
  2. # sudo wget https://enterprise.proxmox.com/debian/proxmox-release-bookworm.gpg -O /etc/apt/trusted.gpg.d/proxmox-release-bookworm.gpg
  3. # sudo apt update
  4. # sudo apt install devscripts debcargo clang
  5. # git clone git://git.proxmox.com/git/proxmox-backup.git
  6. # cd proxmox-backup; sudo mk-build-deps -ir

Note: 2. may be skipped if you already added the PVE or PBS package repository

You are now able to build using the Makefile or cargo itself, e.g.::

  # make deb
  # # or for a non-package build
  # cargo build --all --release

Design Notes
************

Here are some random thought about the software design (unless I find a better place).


Large chunk sizes
=================

It is important to notice that large chunk sizes are crucial for performance.
We have a multi-user system, where different people can do different operations
on a datastore at the same time, and most operation involves reading a series
of chunks.

So what is the maximal theoretical speed we can get when reading a series of
chunks? Reading a chunk sequence need the following steps:

- seek to the first chunk's start location
- read the chunk data
- seek to the next chunk's start location
- read the chunk data
- ...

Lets use the following disk performance metrics:

:AST: Average Seek Time (second)
:MRS: Maximum sequential Read Speed (bytes/second)
:ACS: Average Chunk Size (bytes)

The maximum performance you can get is::

  MAX(ACS) = ACS /(AST + ACS/MRS)

Please note that chunk data is likely to be sequential arranged on disk, but
this it is sort of a best case assumption.

For a typical rotational disk, we assume the following values::

  AST: 10ms
  MRS: 170MB/s

  MAX(4MB)  = 115.37 MB/s
  MAX(1MB)  =  61.85 MB/s;
  MAX(64KB) =   6.02 MB/s;
  MAX(4KB)  =   0.39 MB/s;
  MAX(1KB)  =   0.10 MB/s;

Modern SSD are much faster, lets assume the following::

  max IOPS: 20000 => AST = 0.00005
  MRS: 500Mb/s

  MAX(4MB)  = 474 MB/s
  MAX(1MB)  = 465 MB/s;
  MAX(64KB) = 354 MB/s;
  MAX(4KB)  =  67 MB/s;
  MAX(1KB)  =  18 MB/s;


Also, the average chunk directly relates to the number of chunks produced by
a backup::

  CHUNK_COUNT = BACKUP_SIZE / ACS

Here are some staticics from my developer worstation::

  Disk Usage:       65 GB
  Directories:   58971
  Files:        726314
  Files < 64KB: 617541

As you see, there are really many small files. If we would do file
level deduplication, i.e. generate one chunk per file, we end up with
more than 700000 chunks.

Instead, our current algorithm only produce large chunks with an
average chunks size of 4MB. With above data, this produce about 15000
chunks (factor 50 less chunks).