Go to file
Christian Ebner acfd017b76 sync: pull: refuse to overwrite pre-existing encrypted snapshot
If the source snapshot is not encrypted, the target snapshot however
is pre-existing and there is no decryption key which would detect the
mismatch, the unencrypted source will overwrite the encrypted target
due to resync because of mismatching raw manifests.

Likewise, regular syncs from a different source whose snapshot for
the same backup-time has different content used to silently overwrite
the local target, since byte-wise manifest comparison detects the
mismatch and triggers a resync.

Protect against this by extending the key matching checks, refusing
to overwrite any locally encrypted by a not decrypted source as well
as comparing content by calculating the signature using a dummy key
if both, source and pre-existing target are not encrypted.

Reported-by: Daniel Kral <d.kral@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Link: https://lore.proxmox.com/20260429143740.886870-1-c.ebner@proxmox.com
 [TL: reword bail messages, expand dummy-key comment, fix typos]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2026-04-29 18:23:42 +02:00
.cargo cargo config: add debug=true 2024-06-25 14:21:58 +02:00
debian d/copyright: update years 2026-04-28 23:56:01 +02:00
docs cli: migrate namespace and group move commands from manager to client 2026-04-24 20:52:45 +02:00
etc removable device attach service: improve description 2026-04-29 18:23:42 +02:00
examples clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
pbs-buildcfg add basic multiarch support to resulting package and executable locations 2026-01-21 22:22:17 +01:00
pbs-client client: pxar: regression-test chunk identity end_offset population 2026-04-28 14:46:35 +02:00
pbs-config pbs-config: acls: add 'encryption-keys' as valid 'system' subpath 2026-04-24 00:20:53 +02:00
pbs-datastore run cargo fmt 2026-04-29 09:50:52 +02:00
pbs-fuse-loop clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
pbs-key-config pbs-key-config: introduce store_with() for KeyConfig 2026-04-24 00:20:53 +02:00
pbs-pxar-fuse tree-wide: make hidden lifetimes explicit 2025-11-04 16:40:48 +01:00
pbs-tape fix #7303: tape: handle NUL bytes in SCSI strings better 2026-02-13 10:21:37 +01:00
pbs-tools pbs-tools: buffered logger: drop labels from map once flushed 2026-04-22 21:09:25 +02:00
proxmox-backup-banner tree wide: fix formatting style via cargo fmt 2025-10-31 11:06:21 +01:00
proxmox-backup-client reformat overlong warning, add punctuation 2026-04-28 14:38:46 +02:00
proxmox-file-restore client: migrate commands to flattened repository args 2026-04-19 23:36:39 +02:00
proxmox-restore-daemon clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
pxar-bin tree wide: fix formatting style via cargo fmt 2025-10-31 11:06:21 +01:00
src sync: pull: refuse to overwrite pre-existing encrypted snapshot 2026-04-29 18:23:42 +02:00
templates notification: threshold: format traffic values via template helper 2026-04-08 14:22:41 +02:00
tests clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
www ui: encryption keys: show error text instead of empty popup in API alerts 2026-04-29 18:23:42 +02:00
zsh-completions zsh: fix completions 2021-09-03 10:29:48 +02:00
.gitignore gitignore: generally ignore generated systemd service files 2024-03-08 08:00:30 +01:00
Cargo.toml bump version to 4.2.0-1 2026-04-28 23:56:01 +02:00
defines.mk docs: add datastore.cfg.5 man page 2021-02-10 11:05:02 +01:00
Makefile make: add architecture to upload target 2026-01-21 22:39:33 +01:00
README.rst readme: Add instructions on how to build the docs 2026-02-19 17:11:50 +01:00
rustfmt.toml bump edition in rustfmt.toml 2022-10-13 15:01:11 +02:00
TODO.rst tape: add/use rust scsi changer implementation using libsgutil2 2021-01-25 13:14:07 +01:00

Build & Release Notes
*********************

``rustup`` Toolchain
====================

We normally want to build with the ``rustc`` Debian package (see below). If you
still want to use ``rustup`` for other reasons (e.g. to easily switch between
the official stable, beta, and nightly compilers), you should set the following
``rustup`` configuration to use the Debian-provided ``rustc`` compiler
by default:

    # rustup toolchain link system /usr
    # rustup default system


Versioning of proxmox helper crates
===================================

To use current git master code of the proxmox* helper crates, add::

   git = "git://git.proxmox.com/git/proxmox"

or::

   path = "../proxmox/proxmox"

to the proxmox dependency, and update the version to reflect the current,
pre-release version number (e.g., "0.1.1-dev.1" instead of "0.1.0").


Local cargo config
==================

This repository ships with a ``.cargo/config.toml`` that replaces the crates.io
registry with packaged crates located in ``/usr/share/cargo/registry``.

A similar config is also applied building with dh_cargo. Cargo.lock needs to be
deleted when switching between packaged crates and crates.io, since the
checksums are not compatible.

To reference new dependencies (or updated versions) that are not yet packaged,
the dependency needs to point directly to a path or git source (e.g., see
example for proxmox crate above).


Build
=====
on Debian 12 Bookworm

Setup:
  1. # echo 'deb http://download.proxmox.com/debian/devel/ bookworm main' | sudo tee /etc/apt/sources.list.d/proxmox-devel.list
  2. # sudo wget https://enterprise.proxmox.com/debian/proxmox-release-bookworm.gpg -O /etc/apt/trusted.gpg.d/proxmox-release-bookworm.gpg
  3. # sudo apt update
  4. # sudo apt install devscripts debcargo clang
  5. # git clone git://git.proxmox.com/git/proxmox-backup.git
  6. # cd proxmox-backup; sudo mk-build-deps -ir

Note: 2. may be skipped if you already added the PVE or PBS package repository

You are now able to build using the Makefile or cargo itself, e.g.::

  # make deb
  # # or for a non-package build
  # cargo build --all --release

Building the online documentation
=================================

The online documentation can be build in HTML format as follows. First build the
required binaries::

  make docs

The previous step is only necessary once. Then the online documentation can be
built or regenerated with::

  make -C docs DEB_HOST_RUST_TYPE=x86_64-unknown-linux-gnu html

With the `rust target <https://doc.rust-lang.org/rustc/platform-support.html>`__
of the host. The resulting documentation will be at ``docs/output/html/`` and
can be open with your browser of choice or, e.g. ``xdg-open``.

Design Notes
************

Here are some random thought about the software design (unless I find a better place).


Large chunk sizes
=================

It is important to notice that large chunk sizes are crucial for performance.
We have a multi-user system, where different people can do different operations
on a datastore at the same time, and most operation involves reading a series
of chunks.

So what is the maximal theoretical speed we can get when reading a series of
chunks? Reading a chunk sequence need the following steps:

- seek to the first chunk's start location
- read the chunk data
- seek to the next chunk's start location
- read the chunk data
- ...

Lets use the following disk performance metrics:

:AST: Average Seek Time (second)
:MRS: Maximum sequential Read Speed (bytes/second)
:ACS: Average Chunk Size (bytes)

The maximum performance you can get is::

  MAX(ACS) = ACS /(AST + ACS/MRS)

Please note that chunk data is likely to be sequential arranged on disk, but
this it is sort of a best case assumption.

For a typical rotational disk, we assume the following values::

  AST: 10ms
  MRS: 170MB/s

  MAX(4MB)  = 115.37 MB/s
  MAX(1MB)  =  61.85 MB/s;
  MAX(64KB) =   6.02 MB/s;
  MAX(4KB)  =   0.39 MB/s;
  MAX(1KB)  =   0.10 MB/s;

Modern SSD are much faster, lets assume the following::

  max IOPS: 20000 => AST = 0.00005
  MRS: 500Mb/s

  MAX(4MB)  = 474 MB/s
  MAX(1MB)  = 465 MB/s;
  MAX(64KB) = 354 MB/s;
  MAX(4KB)  =  67 MB/s;
  MAX(1KB)  =  18 MB/s;


Also, the average chunk directly relates to the number of chunks produced by
a backup::

  CHUNK_COUNT = BACKUP_SIZE / ACS

Here are some staticics from my developer workstation::

  Disk Usage:       65 GB
  Directories:   58971
  Files:        726314
  Files < 64KB: 617541

As you see, there are really many small files. If we would do file
level deduplication, i.e. generate one chunk per file, we end up with
more than 700000 chunks.

Instead, our current algorithm only produce large chunks with an
average chunks size of 4MB. With above data, this produce about 15000
chunks (factor 50 less chunks).