Proxmox-Port/proxmox-backup
1
0
Fork 0
forked from proxmox-mirrors/proxmox-backup
Code Pull Requests Activity

cli: add move-namespace and move-group commands

Browse Source 
Add 'move-namespace' and 'move-group' subcommands to
proxmox-backup-manager datastore. Both call the corresponding API
handler and wait for the worker task to complete.

move-namespace accepts optional --max-depth and --delete-source
flags matching the API parameters.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
Link: https://lore.proxmox.com/20260422133951.192862-14-h.laimer@proxmox.com
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Hannes Laimer 2026-04-22 15:39:51 +02:00 committed by Thomas Lamprecht
parent aa3983e068
commit 4d74e20dc0
1 changed files with 112 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

113
src/bin/proxmox_backup_manager/datastore.rs
View File

@ -1,5 +1,6 @@
use pbs_api_types::{
DataStoreConfig, DataStoreConfigUpdater, DATASTORE_SCHEMA, PROXMOX_CONFIG_DIGEST_SCHEMA,
BackupNamespace, DataStoreConfig, DataStoreConfigUpdater, DATASTORE_SCHEMA,
NS_MAX_DEPTH_SCHEMA, PROXMOX_CONFIG_DIGEST_SCHEMA,
};
use pbs_client::view_task_result;
use proxmox_router::{cli::*, ApiHandler, RpcEnvironment};
@ -323,6 +324,100 @@ async fn uuid_mount(mut param: Value, _rpcenv: &mut dyn RpcEnvironment) -> Resul
Ok(Value::Null)
}
#[api(
protected: true,
input: {
properties: {
store: {
schema: DATASTORE_SCHEMA,
},
ns: {
type: BackupNamespace,
},
"target-ns": {
type: BackupNamespace,
},
"max-depth": {
schema: NS_MAX_DEPTH_SCHEMA,
optional: true,
},
"delete-source": {
type: bool,
optional: true,
default: true,
description: "Remove the source namespace after moving all contents. \
Defaults to true.",
},
"merge-groups": {
type: bool,
optional: true,
default: true,
description: "If a group with the same name already exists in the target \
namespace, merge snapshots into it. Requires matching ownership and \
non-overlapping snapshot times.",
},
},
},
)]
/// Move a backup namespace to a new location within the same datastore.
async fn cli_move_namespace(
mut param: Value,
rpcenv: &mut dyn RpcEnvironment,
) -> Result<(), Error> {
param["node"] = "localhost".into();
let info = &api2::admin::namespace::API_METHOD_MOVE_NAMESPACE;
let result = match info.handler {
ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
_ => unreachable!(),
};
crate::wait_for_local_worker(result.as_str().unwrap()).await?;
Ok(())
}
#[api(
protected: true,
input: {
properties: {
store: {
schema: DATASTORE_SCHEMA,
},
ns: {
type: BackupNamespace,
},
group: {
type: pbs_api_types::BackupGroup,
flatten: true,
},
"target-ns": {
type: BackupNamespace,
},
"merge-group": {
type: bool,
optional: true,
default: true,
description: "If the group already exists in the target namespace, merge \
snapshots into it. Requires matching ownership and non-overlapping \
snapshot times.",
},
},
},
)]
/// Move a backup group to a different namespace within the same datastore.
async fn cli_move_group(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
param["node"] = "localhost".into();
let info = &api2::admin::datastore::API_METHOD_MOVE_GROUP;
let result = match info.handler {
ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
_ => unreachable!(),
};
crate::wait_for_local_worker(result.as_str().unwrap()).await?;
Ok(())
}
#[api(
protected: true,
input: {
@ -407,6 +502,22 @@ pub fn datastore_commands() -> CommandLineInterface {
CliCommand::new(&API_METHOD_DELETE_DATASTORE)
.arg_param(&["name"])
.completion_cb("name", pbs_config::datastore::complete_datastore_name),
)
.insert(
"move-namespace",
CliCommand::new(&API_METHOD_CLI_MOVE_NAMESPACE)
.arg_param(&["store"])
.completion_cb("store", pbs_config::datastore::complete_datastore_name)
.completion_cb("ns", crate::complete_sync_local_datastore_namespace)
.completion_cb("target-ns", crate::complete_sync_local_datastore_namespace),
)
.insert(
"move-group",
CliCommand::new(&API_METHOD_CLI_MOVE_GROUP)
.arg_param(&["store"])
.completion_cb("store", pbs_config::datastore::complete_datastore_name)
.completion_cb("ns", crate::complete_sync_local_datastore_namespace)
.completion_cb("target-ns", crate::complete_sync_local_datastore_namespace),
);
cmd_def.into()