virt-viewer/src
Jonathon Jongsma 761149ea71 Screenshot: reject unknown image type filenames
If the image format cannot be determined for a screenshot filename,
simply return an error informing the user that this is not a valid image
format.

In the past, if we couldn't determine the file type, we simply saved it
as a PNG, and appended a ".png" file extension to the filename. This has
several problems. First, it can result in some oddly-named files (e.g. a
screenshot named 'Screenshot.pdf.png').

Second, modifying the filename that is returned from the GtkFileChooser
undermines the overwrite-confirmation functionality that is built into
the gtk file chooser. When the user specifies a filename in the file
chooser dialog, the chooser will automatically check whether a file of
that name exists, and if it does, it will display a dialog asking
whether the user wants to overwrite it. But if we then append a ".png"
extension to the filename and save it, we may be overwriting an existing
file without warning. By returning an error for unrecognized file types,
we avoid this problem.

Resolves: rhbz#1455832
2017-07-20 09:06:46 -05:00
..
resources file-transfer: Fix label of the dialog 2017-03-03 09:37:38 +01:00
debug-helper.c win32: process message queue in debug-helper 2013-02-11 16:54:01 +01:00
Makefile.am Introduce ISO List dialog 2017-01-24 09:48:56 -02:00
ovirt-foreign-menu.c Fix implicit fallthrough warning on new gcc 2017-04-19 15:32:27 +02:00
ovirt-foreign-menu.h ovirt-foreign-menu: Add accessors for current iso and iso list 2017-01-19 13:27:34 -02:00
remote-viewer-connect.c remote-viewer-connect: Keep the 'dialog' window on top 2017-06-12 15:37:28 +02:00
remote-viewer-connect.h remote-viewer-connect: Keep the 'dialog' window on top 2017-06-12 15:37:28 +02:00
remote-viewer-iso-list-dialog.c iso-dialog: Avoid crash when closing dialog early 2017-02-09 17:27:11 -02:00
remote-viewer-iso-list-dialog.h Introduce ISO List dialog 2017-01-24 09:48:56 -02:00
remote-viewer-main.c Include virt-viewer-util.h only in source files 2016-05-31 16:52:46 +02:00
remote-viewer.c remote-viewer-connect: Keep the 'dialog' window on top 2017-06-12 15:37:28 +02:00
remote-viewer.h Port to GtkApplication API's 2016-02-18 21:45:56 +01:00
virt-viewer-app.c kiosk: Show authentication dialog again if cancelled 2017-05-31 10:21:52 -03:00
virt-viewer-app.h Remove unused virt_viewer_app_set_zoom_level 2017-04-04 13:49:21 +02:00
virt-viewer-auth.c ui: Rename UI files to .ui (instead of .xml) 2016-06-20 17:33:53 +02:00
virt-viewer-auth.h Include virt-viewer-util.h only in source files 2016-05-31 16:52:46 +02:00
virt-viewer-display-spice.c Fix missing field initializers 2016-06-22 11:21:13 +02:00
virt-viewer-display-spice.h Fix spice includes 2016-03-24 11:49:39 +01:00
virt-viewer-display-vnc.c vnc: Set display as enabled on init 2017-04-04 17:05:47 +02:00
virt-viewer-display-vnc.h VirtViewerDisplayVnc: set 'session' property 2014-09-24 10:21:22 -05:00
virt-viewer-display.c display: use MIN_DISPLAY_{WIDTH, HEIGHT} as the minimum possible value 2016-06-20 17:09:27 +02:00
virt-viewer-display.h Drop support to gtk2 2016-02-15 21:49:57 +01:00
virt-viewer-enums.c.etemplate build: generate enums type boilerplate 2012-07-23 16:27:32 +02:00
virt-viewer-enums.h.etemplate build: generate enums type boilerplate 2012-07-23 16:27:32 +02:00
virt-viewer-file-transfer-dialog.c Make the progress bar smooth during file-transfer 2017-05-18 15:28:55 +02:00
virt-viewer-file-transfer-dialog.h Add file transfer dialog 2016-05-03 08:04:10 +02:00
virt-viewer-file.c vv-file: Add support for 'sso-token' field in [ovirt] 2016-05-10 09:51:14 +02:00
virt-viewer-file.h vv-file: Add support for 'sso-token' field in [ovirt] 2016-05-10 09:51:14 +02:00
virt-viewer-main.c Include virt-viewer-util.h only in source files 2016-05-31 16:52:46 +02:00
virt-viewer-notebook.c Get rid of deprecated functions to customize widget colors 2016-06-29 10:30:46 -03:00
virt-viewer-notebook.h Update copyright headers 2012-02-06 12:42:18 +00:00
virt-viewer-session-spice.c spice: do not show error on cancel/close of auth dialog 2017-06-05 15:46:46 +02:00
virt-viewer-session-spice.h Fix spice includes 2016-03-24 11:49:39 +01:00
virt-viewer-session-vnc.c vnc: do not show error on cancel/close of auth dialog 2017-06-07 10:06:35 +02:00
virt-viewer-session-vnc.h vnc: add connection by file 2013-01-18 12:28:58 +01:00
virt-viewer-session.c session: Only create a hashtable if apply_monitor_geometry vfunc exists 2015-10-21 15:43:15 +02:00
virt-viewer-session.h Use the display ID to configure fullscreen monitors 2015-10-09 09:17:52 -05:00
virt-viewer-timed-revealer.c timed-revealer: listen to the "grab-notify" signal 2016-06-30 11:51:06 +02:00
virt-viewer-timed-revealer.h timed-revealer: Inherit from GtkEventBox 2016-06-29 01:59:45 +02:00
virt-viewer-util.c util: Fix -Wsign-compare 2017-04-25 10:40:28 +02:00
virt-viewer-util.h util: Fix resource path 2016-06-21 22:54:12 +02:00
virt-viewer-vm-connection.c ui: Rename UI files to .ui (instead of .xml) 2016-06-20 17:33:53 +02:00
virt-viewer-vm-connection.h Set a transient parent for GtkDialogs 2014-12-19 17:39:53 +01:00
virt-viewer-window.c Screenshot: reject unknown image type filenames 2017-07-20 09:06:46 -05:00
virt-viewer-window.h window: Move definition from header 2016-06-22 11:21:13 +02:00
virt-viewer.c virt-viewer: Ensure to not close during migration 2017-05-18 13:46:01 +02:00
virt-viewer.h Port to GtkApplication API's 2016-02-18 21:45:56 +01:00
virt-viewer.manifest win32: add a few Windows sepecific data 2012-03-30 14:48:13 +02:00
virt-viewer.rc.in Use a more descriptive FileDescription 2013-05-23 17:31:05 +02:00
windows-cmdline-wrapper.c win32: there is no CONERR$, only CONOUT$ 2012-10-23 11:17:04 +02:00