mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/virt-viewer
synced 2026-01-05 05:26:27 +00:00
a13173ae64
On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal, remote-viewer crashes as seen in the backtrace below. This can happen over switch-host migration message from SpiceMainChannel. A fix trying to use VirtViewerApp URI avoid the crash but introduces regression while running remote-viewer with ovirt so, keeping the changes to a minimum to avoid it, just use g_intern_string() for now. Found it while improving migrate.py from spice/tests (server): | Invalid free() / delete / delete[] / realloc() | at 0x4839A0C: free (vg_replace_malloc.c:540) | by 0x56EBD8C: g_free (in /usr/lib64/libglib-2.0.so.0.6000.6) | by 0x11DED0: remote_viewer_session_connected (remote-viewer.c:658) | by 0x564D741: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x56614F3: ??? (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566A34D: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566AF68: g_signal_emit_by_name (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x135E5D: virt_viewer_session_spice_main_channel_event (virt-viewer-session-spice.c:699) | by 0x564D741: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x56614F3: ??? (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566A34D: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x53149E3: emit_main_context (gio-coroutine.c:198) | Address 0x18f1ecc0 is 0 bytes inside a block of size 23 free'd | at 0x4839A0C: free (vg_replace_malloc.c:540) | by 0x56EBD8C: g_free (in /usr/lib64/libglib-2.0.so.0.6000.6) | by 0x11DED0: remote_viewer_session_connected (remote-viewer.c:658) | by 0x564D741: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x56614F3: ??? (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566A34D: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566AF68: g_signal_emit_by_name (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x135E5D: virt_viewer_session_spice_main_channel_event (virt-viewer-session-spice.c:699) | by 0x564D741: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x56614F3: ??? (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566A34D: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x53149E3: emit_main_context (gio-coroutine.c:198) | Block was alloc'd at | at 0x483880B: malloc (vg_replace_malloc.c:309) | by 0x56EBC98: g_malloc (in /usr/lib64/libglib-2.0.so.0.6000.6) | by 0x5705C43: g_strdup (in /usr/lib64/libglib-2.0.so.0.6000.6) | by 0x11EB80: remote_viewer_initial_connect (remote-viewer.c:696) | by 0x11EB80: remote_viewer_start (remote-viewer.c:790) | by 0x1250D3: virt_viewer_app_start (virt-viewer-app.c:1727) | by 0x127108: virt_viewer_app_on_application_startup (virt-viewer-app.c:1870) | by 0x564D741: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x5661638: ??? (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566A34D: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x566A972: g_signal_emit (in /usr/lib64/libgobject-2.0.so.0.6000.6) | by 0x553ECA1: g_application_register (in /usr/lib64/libgio-2.0.so.0.6000.6) | by 0x553F41D: g_application_run (in /usr/lib64/libgio-2.0.so.0.6000.6) Signed-off-by: Victor Toso <victortoso@redhat.com> Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com> |
||
|---|---|---|
| .. | ||
| resources | ||
| glib-compat.c | ||
| glib-compat.h | ||
| Makefile.am | ||
| ovirt-foreign-menu.c | ||
| ovirt-foreign-menu.h | ||
| remote-viewer-connect.c | ||
| remote-viewer-connect.h | ||
| remote-viewer-iso-list-dialog.c | ||
| remote-viewer-iso-list-dialog.h | ||
| remote-viewer-main.c | ||
| remote-viewer.c | ||
| remote-viewer.h | ||
| virt-viewer-app.c | ||
| virt-viewer-app.h | ||
| virt-viewer-auth.c | ||
| virt-viewer-auth.h | ||
| virt-viewer-display-spice.c | ||
| virt-viewer-display-spice.h | ||
| virt-viewer-display-vnc.c | ||
| virt-viewer-display-vnc.h | ||
| virt-viewer-display-vte.c | ||
| virt-viewer-display-vte.h | ||
| virt-viewer-display.c | ||
| virt-viewer-display.h | ||
| virt-viewer-enums.c.etemplate | ||
| virt-viewer-enums.h.etemplate | ||
| virt-viewer-file-transfer-dialog.c | ||
| virt-viewer-file-transfer-dialog.h | ||
| virt-viewer-file.c | ||
| virt-viewer-file.h | ||
| virt-viewer-main.c | ||
| virt-viewer-notebook.c | ||
| virt-viewer-notebook.h | ||
| virt-viewer-session-spice.c | ||
| virt-viewer-session-spice.h | ||
| virt-viewer-session-vnc.c | ||
| virt-viewer-session-vnc.h | ||
| virt-viewer-session.c | ||
| virt-viewer-session.h | ||
| virt-viewer-timed-revealer.c | ||
| virt-viewer-timed-revealer.h | ||
| virt-viewer-util.c | ||
| virt-viewer-util.h | ||
| virt-viewer-vm-connection.c | ||
| virt-viewer-vm-connection.h | ||
| virt-viewer-window.c | ||
| virt-viewer-window.h | ||
| virt-viewer.c | ||
| virt-viewer.h | ||
| virt-viewer.manifest | ||
| virt-viewer.rc.in | ||
| windows-cmdline-wrapper.c | ||