pxcloud/virt-viewer
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/virt-viewer synced 2025-12-27 23:00:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
271c51d8de
virt-viewer/src
History
Jonathon Jongsma 271c51d8de Fix inconsistencies in session auth failures 
The spice session implementation can retry authentication on its own,
whereas the vnc session needs to tear down the session and re-connect in
order to retry a failed authentication. This results in the following
inconsistent behavior:

VNC session:
 - emits a 'session-auth-failed' signal when the client does not support
   a particular authentication type (i.e.: a non-recoverable error)
Spice session:
- emits a 'session-auth-failed' signal when user enters an incorrect
  password, and immediately retries auth internally

VNC session:
 - emits a 'session-auth-refused' error when user enters an invalid
   password (i.e.: a recoverable error)
Spice Session:
- never emits a 'session-auth-refused' signal

Because of these differences, the VirtViewerApp code to handle authentication
failures is a bit confusing and difficult to maintain. To fix this issue, make
both the spice and VNC sessions emit the same signal when similar errors occur.
We use the new session API added in the last commit to determine whether the
session supports automatic retries so we know how to handle the signal.
2015-06-19 14:39:48 -05:00
..
view Fix warning when going in/out of fullscreen 2014-08-04 17:41:50 +02:00
debug-helper.c win32: process message queue in debug-helper 2013-02-11 16:54:01 +01:00
gbinding.c Silence unused arguments warnings 2013-05-16 21:54:48 +02:00
gbinding.h Add back compat for GObject 2.22 which lacks GBinding 2012-02-16 14:52:55 +00:00
Makefile.am remote-viewer-connect: Changed hardcoded UI into XML 2015-06-16 14:11:00 +02:00
ovirt-foreign-menu.c ovirt: Add support for an 'admin' key in vv file 2015-04-09 11:34:48 +02:00
ovirt-foreign-menu.h Create foreign menu from .vv file information 2014-08-18 13:20:42 +02:00
remote-viewer-connect.c Add config.h include to remote-viewer-connect.c file 2015-06-19 09:37:23 +01:00
remote-viewer-connect.h remote-viewer-connect: Changed dialog into a window 2015-06-16 14:10:53 +02:00
remote-viewer-connect.xml remote-viewer-connect: Changed hardcoded UI into XML 2015-06-16 14:11:00 +02:00
remote-viewer-main.c Show osid in remote-viewer --version 2015-06-09 18:06:39 +02:00
remote-viewer.c remote-viewer-connect: Changed dialog into a window 2015-06-16 14:10:53 +02:00
remote-viewer.h Improve window title when connected to newer spice-server 2014-02-11 11:56:43 -06:00
test-version-compare.c Add missing config.h header file 2015-06-10 09:32:02 +01:00
virt-glib-compat.c Add missing include of config.h 2013-05-01 16:11:06 +01:00
virt-glib-compat.h Add G_SOURCE_REMOVE to vir-glib-compat 2015-03-11 11:52:43 +01:00
virt-gtk-compat.h Revert changes related to numpad accelerators 2014-09-23 15:00:19 +02:00
virt-viewer-about.xml Update user-visible copyright information 2014-04-04 14:49:20 +02:00
virt-viewer-app.c Fix inconsistencies in session auth failures 2015-06-19 14:39:48 -05:00
virt-viewer-app.h virt-viewer: Set toolbar buttons not sensitive when needed 2015-04-22 11:03:13 +02:00
virt-viewer-auth.c Add support to view the password entry content 2014-09-17 13:45:46 +02:00
virt-viewer-auth.h Change collect_credentials() to return a boolean 2014-08-26 16:54:01 -05:00
virt-viewer-auth.xml Add support to view the password entry content 2014-09-17 13:45:46 +02:00
virt-viewer-display-spice.c display-spice: Do not ignore change of position 2015-04-09 10:47:57 +02:00
virt-viewer-display-spice.h display-spice: Do not ignore change of position 2015-04-09 10:47:57 +02:00
virt-viewer-display-vnc.c Revert "display-vnc: fix zoom-level set by command line" 2015-05-21 13:06:31 +02:00
virt-viewer-display-vnc.h VirtViewerDisplayVnc: set 'session' property 2014-09-24 10:21:22 -05:00
virt-viewer-display.c display: remove useless identation level 2015-04-22 10:40:29 +02:00
virt-viewer-display.h virt-viewer-display: Use MIN_DISPLAY_WIDTH/HEIGHT instead of numbers 2015-04-02 09:21:32 +02:00
virt-viewer-enums.c.etemplate build: generate enums type boilerplate 2012-07-23 16:27:32 +02:00
virt-viewer-enums.h.etemplate build: generate enums type boilerplate 2012-07-23 16:27:32 +02:00
virt-viewer-events.c win: Use correct format string for intptr_t 2015-01-02 13:49:05 +01:00
virt-viewer-events.h Update copyright headers 2012-02-06 12:42:18 +00:00
virt-viewer-file.c vv-file: Show 'newer-version-url' when version check fails 2015-06-09 18:06:39 +02:00
virt-viewer-file.h vv-file: Add 'newer-version-url' key to .vv files 2015-06-09 18:06:39 +02:00
virt-viewer-guest-details.xml Add a dialog showing details of the current guest 2014-08-07 08:51:15 -05:00
virt-viewer-main.c virt-viewer-main: '--wait' should not be used without domain name 2015-04-14 18:22:01 +02:00
virt-viewer-notebook.c Remove unused VirtViewerNotebook::dispose 2014-08-04 17:41:50 +02:00
virt-viewer-notebook.h Update copyright headers 2012-02-06 12:42:18 +00:00
virt-viewer-preferences.xml Add preferences dialog UI file 2015-03-05 21:31:30 +01:00
virt-viewer-session-spice.c Fix inconsistencies in session auth failures 2015-06-19 14:39:48 -05:00
virt-viewer-session-spice.h spice: implement --fullscreen=auto-conf 2012-03-21 16:20:37 +01:00
virt-viewer-session-vnc.c session-vnc: Set window for display to avoid gtk-vnc v0.3.8 crash 2015-05-21 13:06:31 +02:00
virt-viewer-session-vnc.h vnc: add connection by file 2013-01-18 12:28:58 +01:00
virt-viewer-session.c Session: add vfunc to check auth retry capability 2015-06-19 14:39:48 -05:00
virt-viewer-session.h Session: add vfunc to check auth retry capability 2015-06-19 14:39:48 -05:00
virt-viewer-util.c util: Replace virt_viewer_compare_version with _compare_buildid 2015-06-09 18:06:39 +02:00
virt-viewer-util.h util: Replace virt_viewer_compare_version with _compare_buildid 2015-06-09 18:06:39 +02:00
virt-viewer-vm-connection.c Exit normally when canceling dialog 2015-03-23 19:32:02 +01:00
virt-viewer-vm-connection.h Set a transient parent for GtkDialogs 2014-12-19 17:39:53 +01:00
virt-viewer-vm-connection.xml virt-viewer: Fix choose VM dialog alt-tab in gnome2 2015-05-21 13:06:31 +02:00
virt-viewer-window.c Fix syntax-check 2015-04-29 10:29:52 +02:00
virt-viewer-window.h virt-viewer: Set toolbar buttons not sensitive when needed 2015-04-22 11:03:13 +02:00
virt-viewer.c virt-viewer: Set toolbar buttons not sensitive when needed 2015-04-22 11:03:13 +02:00
virt-viewer.h Try to share more GOption code between r-v and v-v 2013-08-20 13:39:46 +02:00
virt-viewer.manifest win32: add a few Windows sepecific data 2012-03-30 14:48:13 +02:00
virt-viewer.rc.in Use a more descriptive FileDescription 2013-05-23 17:31:05 +02:00
virt-viewer.xml Show preferences dialog 2015-03-05 21:31:31 +01:00
windows-cmdline-wrapper.c win32: there is no CONERR$, only CONOUT$ 2012-10-23 11:17:04 +02:00