From f0c6bb27f48d8482684809b4ea9bda4f6c0122e0 Mon Sep 17 00:00:00 2001 From: Jonathon Jongsma Date: Tue, 14 Apr 2015 14:38:13 -0500 Subject: [PATCH] SessionSpice: Protect against unreffing window twice In theory, the dispose method can be called multiple times, so any member variables that are unreffed should be set to NULL so that we don't accidentally unref them multiple times. --- src/virt-viewer-session-spice.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c index da193ec..717d229 100644 --- a/src/virt-viewer-session-spice.c +++ b/src/virt-viewer-session-spice.c @@ -145,8 +145,7 @@ virt_viewer_session_spice_dispose(GObject *obj) spice->priv->audio = NULL; - if (spice->priv->main_window) - g_object_unref(spice->priv->main_window); + g_clear_object(&spice->priv->main_window); G_OBJECT_CLASS(virt_viewer_session_spice_parent_class)->dispose(obj); }