pxcloud/virt-viewer
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/virt-viewer synced 2025-12-31 20:04:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Let the user cancel the SPICE auth dialog

Browse Source 
virt_viewer_auth_collect_credentials() was recently changed to return
a boolean instead of an integer (2561c171). This change introduced a
regression in the authentication dialog behavior, making it impossible
for the user to cancel.
This commit is contained in:
Fabiano Fidêncio 2014-09-23 16:58:14 +02:00
parent 141d69b7f5
commit ec5a661469
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/virt-viewer-session-spice.c
View File

@ -482,7 +482,7 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED
{
VirtViewerSessionSpice *self = VIRT_VIEWER_SESSION_SPICE(session);
gchar *password = NULL, *user = NULL;
int ret;
gboolean ret;
g_return_if_fail(self != NULL);
@ -513,7 +513,7 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED
"SPICE",
NULL,
NULL, &password);
if (ret < 0) {
if (!ret) {
g_signal_emit_by_name(session, "session-cancelled");
} else {
gboolean openfd;
@ -542,7 +542,7 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED
ret = virt_viewer_auth_collect_credentials(self->priv->main_window,
"proxy", NULL,
&user, &password);
if (ret < 0) {
if (!ret) {
g_signal_emit_by_name(session, "session-cancelled");
} else {
spice_uri_set_user(proxy, user);