From c543941a1795cabb75307d2e49237d03ddd3cb26 Mon Sep 17 00:00:00 2001 From: Jonathon Jongsma Date: Wed, 8 Apr 2015 16:41:05 -0500 Subject: [PATCH] Cleanup: only add display when it's created This wasn't causing any problems because the _add_display() function has an early return for the case that the display has already been added to the session, but it's quite confusing when reading the code to see this _add_display() function being called for every display every time we get a monitor configuration update. --- src/virt-viewer-session-spice.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c index ccd869e..da193ec 100644 --- a/src/virt-viewer-session-spice.c +++ b/src/virt-viewer-session-spice.c @@ -727,10 +727,9 @@ virt_viewer_session_spice_display_monitors(SpiceChannel *channel, display = virt_viewer_display_spice_new(self, channel, i); g_debug("creating spice display (#:%d)", i); g_ptr_array_index(displays, i) = g_object_ref_sink(display); + virt_viewer_session_add_display(VIRT_VIEWER_SESSION(self), + VIRT_VIEWER_DISPLAY(display)); } - - virt_viewer_session_add_display(VIRT_VIEWER_SESSION(self), - VIRT_VIEWER_DISPLAY(display)); } for (i = 0; i < monitors->len; i++) {