pxcloud/virt-viewer
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/virt-viewer synced 2026-01-07 19:57:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Display warning if UI file fails

Browse Source 
When trying to load ui files, we try to find the file in several directories.
If a file is not found in one directory, try to load it from the next directory.
However, if a file is found in a directory but we are not able to load it (e.g.
due to unsupported versions of glade used to generate it, etc), we should print
a warning to the terminal to help the developer debug the issue.

This is an unexpected failure (whereas not finding the file in that directory at
all is an 'expected' failure).
This commit is contained in:
Jonathon Jongsma 2014-01-20 10:28:40 -06:00
parent 03a3ba68a5
commit bee13a6a59
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/virt-viewer-util.c
View File

@ -58,7 +58,12 @@ GtkBuilder *virt_viewer_util_load_ui(const char *name)
gtk_builder_add_from_file(builder, name, &error);
} else {
gchar *path = g_build_filename(PACKAGE_DATADIR, "ui", name, NULL);
gboolean success = (gtk_builder_add_from_file(builder, path, NULL) != 0);
gboolean success = (gtk_builder_add_from_file(builder, path, &error) != 0);
if (error) {
if (!(error->domain == G_FILE_ERROR && error->code == G_FILE_ERROR_NOENT))
g_warning("Failed to add ui file '%s': %s", path, error->message);
g_clear_error(&error);
}
g_free(path);
if (!success) {