pxcloud/virt-viewer
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/virt-viewer synced 2025-12-29 08:42:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove useless 'if (...)' before free()

Browse Source 
The 'free()' function accepts NULL, so you should not
check for NULL before calling it.
This commit is contained in:
Daniel P. Berrange 2014-10-27 16:38:06 +00:00
parent f0d662994f
commit bd6fd964f9
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/remote-viewer.c
View File

@ -1148,9 +1148,7 @@ choose_vm(char **vm_name, OvirtCollection *vms_collection, GError **error)
OvirtVm *vm;
g_return_val_if_fail(vm_name != NULL, NULL);
if (*vm_name != NULL) {
free(*vm_name);
}
free(*vm_name);
model = gtk_list_store_new(1, G_TYPE_STRING);

4
src/virt-viewer.c
View File

@ -555,9 +555,7 @@ choose_vm(char **vm_name, virConnectPtr conn, GError **error)
unsigned int flags = VIR_CONNECT_LIST_DOMAINS_RUNNING;
g_return_val_if_fail(vm_name != NULL, NULL);
if (*vm_name != NULL) {
free(*vm_name);
}
free(*vm_name);
model = gtk_list_store_new(1, G_TYPE_STRING);