pxcloud/virt-viewer
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/virt-viewer synced 2026-01-24 08:22:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Auth: fix leak of username

Browse Source 
When collect_credentials() returns a failure status, 'username' was
potentially leaked.
This commit is contained in:
Jonathon Jongsma 2014-08-12 11:01:46 -05:00
parent ad8966ccf9
commit b7c8049460
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/remote-viewer.c
View File

@ -744,17 +744,16 @@ authenticate_cb(RestProxy *proxy, G_GNUC_UNUSED RestProxyAuth *auth,
"oVirt",
NULL,
&username, &password);
if (ret < 0) {
return FALSE;
} else {
if (ret == 0) {
g_object_set(G_OBJECT(proxy),
"username", username,
"password", password,
NULL);
g_free(username);
g_free(password);
return TRUE;
}
g_free(username);
g_free(password);
return (ret == 0);
}