From 5daeea567cba7d486228936acd8ff5fcb7008f3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Tue, 12 Feb 2019 14:23:12 +0000 Subject: [PATCH] Declare VirtViewerFile variable at start of method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit virt_viewer_session_vnc_auth_credential uses gotos which jump over the declaration of 'file', meaning its contents are uninitialized in the jump target. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé --- src/virt-viewer-session-vnc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/virt-viewer-session-vnc.c b/src/virt-viewer-session-vnc.c index e7c8cad..31d5361 100644 --- a/src/virt-viewer-session-vnc.c +++ b/src/virt-viewer-session-vnc.c @@ -273,6 +273,7 @@ virt_viewer_session_vnc_auth_credential(GtkWidget *src G_GNUC_UNUSED, VirtViewerSessionVnc *self = VIRT_VIEWER_SESSION_VNC(session); char *username = NULL, *password = NULL; gboolean wantPassword = FALSE, wantUsername = FALSE; + VirtViewerFile *file = NULL; int i; g_debug("Got VNC credential request for %u credential(s)", credList->n_values); @@ -295,7 +296,7 @@ virt_viewer_session_vnc_auth_credential(GtkWidget *src G_GNUC_UNUSED, } } - VirtViewerFile *file = virt_viewer_session_get_file(VIRT_VIEWER_SESSION(self)); + file = virt_viewer_session_get_file(VIRT_VIEWER_SESSION(self)); if (file != NULL) { if (wantUsername) { if (virt_viewer_file_is_set(file, "username")) {