pxcloud/virt-viewer
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/virt-viewer synced 2025-12-28 07:06:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't hardcode 'localhost' in no @listen parameter is given

Browse Source 
If no @listen parameter is given, we must not hardcode 'localhost'
since we can't assume we are running on the same host. Instead use
the hostname from the connection URI
This commit is contained in:
Daniel P. Berrange 2012-02-14 14:55:39 +00:00
parent a52b9f3182
commit 56b0217c62
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/virt-viewer.c
View File

@ -332,8 +332,6 @@ virt_viewer_extract_connect_info(VirtViewer *self,
free(xpath);
xpath = g_strdup_printf("string(/domain/devices/graphics[@type='%s']/@listen)", type);
ghost = virt_viewer_extract_xpath_string(xmldesc, xpath);
if (ghost == NULL)
ghost = g_strdup("localhost");
}
if (ghost && gport)
@ -353,11 +351,11 @@ virt_viewer_extract_connect_info(VirtViewer *self,
* from a remote host. Instead we fallback to the hostname used in
* the libvirt URI. This isn't perfect but it is better than nothing
*/
if (ghost &&
if (!ghost ||
(strcmp(ghost, "0.0.0.0") == 0 ||
strcmp(ghost, "::") == 0)) {
DEBUG_LOG("Guest graphics listen '%s' is a wildcard, replacing with '%s'",
ghost, host);
DEBUG_LOG("Guest graphics listen '%s' is NULL or a wildcard, replacing with '%s'",
ghost ? ghost : "", host);
g_free(ghost);
ghost = g_strdup(host);
}