Commit Graph

13 Commits

Author SHA1 Message Date
Manos Pitsidianakis
cd0557ec71 console: run clippy --fix
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2025-07-18 10:05:07 +02:00
Manos Pitsidianakis
8bd01f2ffb console: fix minor typo
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2025-07-07 11:28:02 +03:00
Wenyu Huang
91a625603f chore: bump virtio-queue and some related dependencies
virtio-queue v0.15 introduces a new Descriptor API supporting both
split and packed virtqueue.
Update our dependencies and code to work with the new version
of the crate, including updating vhost-user-backend and virtio-vsock.

Updates `vhost-user-backend` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/rust-vmm/vhost/releases)
- [Commits](rust-vmm/vhost@vhost-user-backend-v0.18.0...vhost-user-backend-v0.19.0)

Updates `virtio-queue` from 0.14.0 to 0.15.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.14.0...virtio-queue-v0.15.0)

Updates `virtio-vsock` from 0.8.0 to 0.9.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-vsock-v0.8.0...virtio-vsock-v0.9.0)

Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
2025-06-23 21:36:11 +02:00
Ruoqing He
d43fd79bb7 clippy: Fix clippy::precedence
Fix `clippy::precedence` warnings reported by clippy 0.1.85 (4d91de4e48
2025-02-17).

```console
error: operator precedence can trip the unwary
   --> vhost-device-template/src/vhu_foo.rs:152:9
    |
152 | /         1 << VIRTIO_F_VERSION_1
153 | |             | 1 << VIRTIO_F_NOTIFY_ON_EMPTY
154 | |             | 1 << VIRTIO_RING_F_INDIRECT_DESC
155 | |             | 1 << VIRTIO_RING_F_EVENT_IDX
    | |__________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
    = note: `-D clippy::precedence` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::precedence)]`
help: consider parenthesizing your expression
    |
152 ~         1 << VIRTIO_F_VERSION_1
153 +             | 1 << VIRTIO_F_NOTIFY_ON_EMPTY
154 +             | 1 << VIRTIO_RING_F_INDIRECT_DESC | (1 << VIRTIO_RING_F_EVENT_IDX)
    |
```

Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
2025-03-31 13:45:27 +02:00
Xuewei Niu
04c30f700a vhost-device-console: Being able to specify max queue size
Some hypervisors, e.g. UML, negotiate a queue size larger than `QUEUE_SIZE`
(128), which results in failures. This patch allows users to specify it
using `--max-queue-size <size>`.

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
2025-02-14 12:51:22 +02:00
Manos Pitsidianakis
ad30537ab0 console: add crate-level clippy lints
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2024-11-14 13:00:05 +02:00
Manos Pitsidianakis
8a2a11d877 console: run nightly rustfmt to group imports
Nightly rustfmt groups imports neatly, so run it to make things
prettier.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2024-11-14 13:00:05 +02:00
Manos Pitsidianakis
c3a346c63a console: move event constants to QueueEvent enum
For the purpose of "namespacing" them under the enum type.

While at it, move QUEUE_SIZE and NUM_QUEUES as related constants for
VhostUserConsoleBackend.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2024-11-14 13:00:05 +02:00
Manos Pitsidianakis
084d7ed082 console: specify unknown event in HandleEventUnknown
Since we know the unknown event value, we might as well specify it in
the error message of Error::HandleEventUnknown to help users and
developers.

While at it, return an error when trying to access vrings with
`device_event` >= QUEUE_SIZE.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2024-11-14 13:00:05 +02:00
Manos Pitsidianakis
03bf860b28 console: remove extraneous convert::From use
std::convert::From is included in the prelude, so no need to refer to it
by its full path.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2024-11-14 13:00:05 +02:00
Manos Pitsidianakis
c7d4bf6f63 console: remove extraneous newline from expect()
expect(), like panic!(), does not trailing need newlines. Remove them.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2024-11-14 13:00:05 +02:00
Manos Pitsidianakis
ab9a8af504 console: fix wording for CouldNotInitBackend error
Human readable text for this error variant was copied from
CouldNotCreateBackend, so adjust it for its own purpose.

Fixes: c739770 ("vhost-device-console: use worker's epoll for input events")
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
2024-11-14 13:00:05 +02:00
Timos Ampelikiotis
0b06c22096 vhost-device-console: promote to main workspace
The current implementation seems ready to be promoted to the
main workspace since the device supports test coverage have been
increased and the basic functionality is implemented.

Cargo.lock files both in main and staging workspaces are updated.

Support for VIRTIO_CONSOLE_F_SIZE and VIRTIO_CONSOLE_F_EMERG_WRITE
is still missing.

Signed-off-by: Timos Ampelikiotis <t.ampelikiotis@virtualopensystems.com>
2024-11-09 16:41:28 +00:00