pxcloud/vhost-device
5
0
Fork 0
mirror of https://github.com/rust-vmm/vhost-device.git synced 2026-01-09 14:19:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[i2c] Use hashmap for device_map

Browse Source 
Use hashmap instead of an array of size 1 << 7, as only a few entries of
the array are used here.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Viresh Kumar 2021-10-22 12:00:24 +05:30
parent 91d84b481e
commit fedfb0b82e
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/i2c/src/i2c.rs
View File

@ -6,6 +6,7 @@
// SPDX-License-Identifier: Apache-2.0
use log::info;
use std::collections::HashMap;
use std::fs::{File, OpenOptions};
use std::os::unix::io::AsRawFd;
@ -444,11 +445,10 @@ impl<D: I2cDevice> I2cAdapter<D> {
/// I2C map and helpers
pub(crate) const MAX_I2C_VDEV: usize = 1 << 7;
const I2C_INVALID_ADAPTER: u32 = 0xFFFFFFFF;
pub struct I2cMap<D: I2cDevice> {
adapters: Vec<I2cAdapter<D>>,
device_map: [u32; MAX_I2C_VDEV],
device_map: HashMap<u16, usize>,
}
impl<D: I2cDevice> I2cMap<D> {
@ -456,7 +456,7 @@ impl<D: I2cDevice> I2cMap<D> {
where
Self: Sized,
{
let mut device_map: [u32; MAX_I2C_VDEV] = [I2C_INVALID_ADAPTER; MAX_I2C_VDEV];
let mut device_map = HashMap::new();
let mut adapters: Vec<I2cAdapter<D>> = Vec::new();
for (i, device_cfg) in device_config.inner.iter().enumerate() {
@ -466,7 +466,7 @@ impl<D: I2cDevice> I2cMap<D> {
// Check that all addresses corresponding to the adapter are valid.
for addr in &device_cfg.addr {
adapter.set_device_addr(*addr as usize)?;
device_map[*addr as usize] = i as u32;
device_map.insert(*addr, i);
}
info!(
@ -484,21 +484,21 @@ impl<D: I2cDevice> I2cMap<D> {
}
pub fn transfer(&self, reqs: &mut [I2cReq]) -> Result<()> {
let device = reqs[0].addr as usize;
let device = reqs[0].addr;
// identify the device in the device_map
let index = self.device_map[device];
let index = match self.device_map.get(&device) {
Some(&index) => index,
// This can happen a lot while scanning the bus, don't print any errors.
if index == I2C_INVALID_ADAPTER {
return Err(Error::ClientAddressInvalid);
}
// This can happen a lot while scanning the bus, don't print any errors.
None => return Err(Error::ClientAddressInvalid),
};
// get the corresponding adapter based on the device config.
let adapter = &self.adapters[index as usize];
// Set device's address
adapter.set_device_addr(device)?;
adapter.set_device_addr(device as usize)?;
adapter.transfer(reqs)
}
}
@ -562,11 +562,11 @@ pub mod tests {
assert_eq!(i2c_map.adapters[1].adapter_no(), 2);
assert_eq!(i2c_map.adapters[2].adapter_no(), 5);
assert_eq!(i2c_map.device_map[4], 0);
assert_eq!(i2c_map.device_map[32], 1);
assert_eq!(i2c_map.device_map[21], 1);
assert_eq!(i2c_map.device_map[10], 2);
assert_eq!(i2c_map.device_map[23], 2);
assert_eq!(i2c_map.device_map.get(&4), Some(&0));
assert_eq!(i2c_map.device_map.get(&32), Some(&1));
assert_eq!(i2c_map.device_map.get(&21), Some(&1));
assert_eq!(i2c_map.device_map.get(&10), Some(&2));
assert_eq!(i2c_map.device_map.get(&23), Some(&2));
}
#[test]