pxcloud/vhost-device
5
0
Fork 0
mirror of https://github.com/rust-vmm/vhost-device.git synced 2025-12-29 00:41:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

i2c: Trim the device list to avoid errors

Browse Source 
If the user passes device list with whitespace before or after, like -l
" 6:32", then " 6".parse::<u32>() fails. Fix this by trimming the
argument for whitespace at start or end.

Also add a test for the same.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Viresh Kumar 2022-02-17 17:00:21 +05:30
parent 819fedbbae
commit d052e66bbe
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
i2c/src/main.rs
View File

@ -163,7 +163,7 @@ impl TryFrom<I2cArgs> for I2cConfiguration {
return Err(Error::SocketCountInvalid(0));
}
let devices = AdapterConfig::try_from(args.device_list.as_str())?;
let devices = AdapterConfig::try_from(args.device_list.trim())?;
Ok(I2cConfiguration {
socket_path: args.socket_path,
socket_count: args.socket_count,
@ -324,6 +324,11 @@ mod tests {
fn test_parse_successful() {
let socket_name = "vi2c.sock";
// Space before and after the device list
let cmd_args = I2cArgs::from_args(socket_name, " 1:4 ", 1);
I2cConfiguration::try_from(cmd_args).unwrap();
// Valid configuration
let cmd_args = I2cArgs::from_args(socket_name, "1:4,2:32:21,5:5:23", 5);
let config = I2cConfiguration::try_from(cmd_args).unwrap();