pxcloud/vhost-device
5
0
Fork 0
mirror of https://github.com/rust-vmm/vhost-device.git synced 2025-12-27 15:45:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

scmi: Use new_device for ScmiDevice constructors

Browse Source 
Instead of `new', which should be reserved for direct constructors.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
This commit is contained in:
Milan Zamazal 2023-08-07 20:52:53 +02:00 committed by Alex Bennée
parent 789288c372
commit c1637e94b8
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/scmi/src/devices/common.rs
View File

@ -128,7 +128,7 @@ pub fn available_devices() -> NameDeviceMapping {
devices.insert(
"fake",
DeviceSpecification::new(
fake::FakeSensor::new,
fake::FakeSensor::new_device,
"fake accelerometer",
"A simple 3-axes sensor providing fake pre-defined values.",
&["name: an optional name of the sensor, max. 15 characters"],

3
crates/scmi/src/devices/fake.rs
View File

@ -51,8 +51,7 @@ impl SensorT for FakeSensor {
}
impl FakeSensor {
#[allow(clippy::new_ret_no_self)]
pub fn new(properties: &DeviceProperties) -> MaybeDevice {
pub fn new_device(properties: &DeviceProperties) -> MaybeDevice {
properties.check(&[], &["name"])?;
let sensor = Sensor::new(properties, "fake");
let fake_sensor = Self { sensor, value: 0 };

2
crates/scmi/src/scmi.rs
View File

@ -870,7 +870,7 @@ mod tests {
let mut handler = ScmiHandler::new();
for i in 0..2 {
let properties = DeviceProperties::new(vec![("name".to_owned(), format!("fake{i}"))]);
let fake_sensor = FakeSensor::new(&properties).unwrap();
let fake_sensor = FakeSensor::new_device(&properties).unwrap();
handler.register_device(fake_sensor);
}
handler