pxcloud/vhost-device
5
0
Fork 0
mirror of https://github.com/rust-vmm/vhost-device.git synced 2026-01-06 10:23:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[i2c] Add tests to validate data

Browse Source 
Add tests to validate the data processed by rdwr() and smbus(). The
coverage score went up significantly as a result of all recent tests.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Viresh Kumar 2021-11-16 16:46:34 +05:30
parent 97e58e8201
commit 5af15e89bf
2 changed files with 125 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
coverage_config_x86_64.json
View File

@ -1,5 +1,5 @@
{
"coverage_score": 42.9,
"coverage_score": 59.8,
"exclude_path": "",
"crate_features": ""
}

135
src/i2c/src/i2c.rs
View File

@ -604,11 +604,24 @@ pub mod tests {
self.funcs_result
}
fn rdwr(&self, _reqs: &mut [I2cReq]) -> Result<()> {
fn rdwr(&self, reqs: &mut [I2cReq]) -> Result<()> {
// Update buffer of each write-buffer with index + 1 value.
for req in reqs {
if (req.flags & I2C_M_RD) != 0 {
for (j, byte) in req.buf.iter_mut().enumerate() {
*byte = j as u8 + 1;
}
}
}
self.rdwr_result
}
fn smbus(&self, _msg: &mut SmbusMsg) -> Result<()> {
fn smbus(&self, msg: &mut SmbusMsg) -> Result<()> {
// Update data unconditionally to 1 and 2.
if let Some(data) = &mut msg.data {
data.word = 0x0201;
}
self.smbus_result
}
@ -621,6 +634,17 @@ pub mod tests {
}
}
fn verify_rdwr_data(reqs: &[I2cReq]) {
// Match what's done by DummyDevice::rdwr()
for req in reqs {
if (req.flags & I2C_M_RD) != 0 {
for (i, byte) in req.buf.iter().enumerate() {
assert_eq!(*byte, i as u8 + 1);
}
}
}
}
#[test]
fn test_funcs() {
let i2c_device = DummyDevice {
@ -671,14 +695,42 @@ pub mod tests {
i2c_map.adapters[0].smbus = false;
let mut reqs: Vec<I2cReq> = vec![I2cReq {
addr: 0x3,
flags: 0,
len: 2,
buf: vec![7, 4],
}];
// Read-Write-Read-Write-Read block
let mut reqs: Vec<I2cReq> = vec![
I2cReq {
addr: 0x3,
flags: I2C_M_RD,
len: 20,
buf: vec![0; 20],
},
I2cReq {
addr: 0x3,
flags: 0,
len: 10,
buf: vec![0; 10],
},
I2cReq {
addr: 0x3,
flags: I2C_M_RD,
len: 25,
buf: vec![0; 25],
},
I2cReq {
addr: 0x3,
flags: 0,
len: 11,
buf: vec![0; 11],
},
I2cReq {
addr: 0x3,
flags: I2C_M_RD,
len: 30,
buf: vec![0; 30],
},
];
i2c_map.transfer(&mut *reqs).unwrap();
verify_rdwr_data(&reqs);
}
#[test]
@ -688,6 +740,48 @@ pub mod tests {
i2c_map.adapters[0].smbus = true;
// I2C_SMBUS_WRITE (I2C_SMBUS_QUICK) operation
let mut reqs: Vec<I2cReq> = vec![I2cReq {
addr: 0x3,
flags: 0,
len: 0,
buf: vec![0],
}];
i2c_map.transfer(&mut reqs).unwrap();
// I2C_SMBUS_READ (I2C_SMBUS_QUICK) operation
let mut reqs: Vec<I2cReq> = vec![I2cReq {
addr: 0x3,
flags: I2C_M_RD,
len: 0,
buf: vec![0],
}];
i2c_map.transfer(&mut reqs).unwrap();
// I2C_SMBUS_WRITE (I2C_SMBUS_BYTE) operation
let mut reqs: Vec<I2cReq> = vec![I2cReq {
addr: 0x3,
flags: 0,
len: 1,
buf: vec![0],
}];
i2c_map.transfer(&mut reqs).unwrap();
// I2C_SMBUS_READ (I2C_SMBUS_BYTE) operation
let mut reqs: Vec<I2cReq> = vec![I2cReq {
addr: 0x3,
flags: I2C_M_RD,
len: 1,
buf: vec![0],
}];
i2c_map.transfer(&mut reqs).unwrap();
assert_eq!(reqs[0].buf[0], 1);
// I2C_SMBUS_WRITE (I2C_SMBUS_BYTE_DATA) operation
let mut reqs: Vec<I2cReq> = vec![I2cReq {
addr: 0x3,
flags: 0,
@ -695,25 +789,44 @@ pub mod tests {
buf: [7, 4].to_vec(),
}];
// I2C_SMBUS_WRITE (I2C_SMBUS_BYTE_DATA) operation
i2c_map.transfer(&mut reqs).unwrap();
// I2C_SMBUS_READ (I2C_SMBUS_BYTE_DATA) operation
let mut reqs = vec![
I2cReq {
addr: 0x3,
flags: 0,
len: 1,
buf: vec![0],
},
I2cReq {
addr: 0x3,
flags: I2C_M_RD,
len: 1,
buf: vec![0],
},
];
i2c_map.transfer(&mut reqs).unwrap();
assert_eq!(reqs[1].buf[0], 1);
// I2C_SMBUS_READ (I2C_SMBUS_WORD_DATA) operation
let mut reqs = vec![
I2cReq {
addr: 0x3,
flags: 0,
len: 1,
buf: [34].to_vec(),
buf: vec![0],
},
I2cReq {
addr: 0x3,
flags: I2C_M_RD,
len: 2,
buf: [3, 4].to_vec(),
buf: vec![0; 2],
},
];
i2c_map.transfer(&mut reqs).unwrap();
assert_eq!(reqs[1].buf[0], 1);
assert_eq!(reqs[1].buf[1], 2);
}
#[test]