pxcloud/vhost-device
5
0
Fork 0
mirror of https://github.com/rust-vmm/vhost-device.git synced 2025-12-30 01:42:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[i2c] Always update and validate buffers

Browse Source 
Not just read-buffers, also validate write buffers for rdwr() tests.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Viresh Kumar 2021-11-17 20:33:49 +05:30
parent bb140619e8
commit 0cc0fe4f7a
1 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/i2c/src/i2c.rs
View File

@ -574,6 +574,20 @@ pub mod tests {
use std::convert::TryFrom;
use vmm_sys_util::tempfile::TempFile;
// Update read-buffer of each write-buffer with index + 1 value.
pub fn update_rdwr_buf(buf: &mut Vec<u8>) {
for (i, byte) in buf.iter_mut().enumerate() {
*byte = i as u8 + 1;
}
}
// Verify the write-buffer passed to us
pub fn verify_rdwr_buf(buf: &[u8]) {
for (i, byte) in buf.iter().enumerate() {
assert_eq!(*byte, i as u8 + 1);
}
}
#[derive(Debug)]
pub struct DummyDevice {
funcs_result: Result<u64>,
@ -611,12 +625,15 @@ pub mod tests {
}
fn rdwr(&self, reqs: &mut [I2cReq]) -> Result<()> {
// Update buffer of each write-buffer with index + 1 value.
for req in reqs {
if req.len == 0 {
return Err(Error::I2cTransferInvalid(0));
}
if (req.flags & I2C_M_RD) != 0 {
for (j, byte) in req.buf.iter_mut().enumerate() {
*byte = j as u8 + 1;
}
update_rdwr_buf(&mut req.buf);
} else {
verify_rdwr_buf(&req.buf);
}
}
@ -644,9 +661,7 @@ pub mod tests {
// Match what's done by DummyDevice::rdwr()
for req in reqs {
if (req.flags & I2C_M_RD) != 0 {
for (i, byte) in req.buf.iter().enumerate() {
assert_eq!(*byte, i as u8 + 1);
}
verify_rdwr_buf(&req.buf);
}
}
}
@ -735,6 +750,12 @@ pub mod tests {
},
];
for req in &mut reqs {
if (req.flags & I2C_M_RD) == 0 {
update_rdwr_buf(&mut req.buf);
}
}
i2c_map.transfer(&mut *reqs).unwrap();
verify_rdwr_data(&reqs);
}