mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice
synced 2026-01-05 06:00:43 +00:00
15b1e2a3bb
When SASL is active, if a read request is made and SASL buffer contains some data (but not enough to fulfill the request), upon return the taken data from the buffer is not accounted for and hence part of the message gets discarded. red_stream_sasl_read function takes available data from sasl buffer and returns if it's enough. If it's not, nbyte is decremented and buf pointer is incremented to account for the taken data (if any). Then it tries to get more data from the socket and decode it. Suppose there was some data in the sasl buffer, but not enough. Then the socket is not readable (EAGAIN, EINTR, whatever) or the new data isn't enough for sasl_decode (hence decodedlen == 0). In both cases the function returns as if no data was read, but it took some data from sasl buffer. This data is lost and from this point on the communication ceases on the channel (eventually new data is read, but messages are corrupt without the parts previously discarded). On the other hand, if some data is read from sasl buffer and everything else works fine, the output buffer contains all the data, but the count returned only inform the caller about the newly read data (which causes the similar effect of discarding part of the message). Fixes: https://gitlab.freedesktop.org/spice/spice/-/issues/40 Acked-by: Frediano Ziglio <fziglio@redhat.com>
83 lines
3.0 KiB
Plaintext
83 lines
3.0 KiB
Plaintext
Spice Authors
|
|
=============
|
|
|
|
The current active Spice maintainers are
|
|
|
|
Christophe Fergeau <cfergeau@redhat.com>
|
|
Frediano Ziglio <fziglio@redhat.com>
|
|
Jonathon Jongsma <jjongsma@redhat.com>
|
|
Uri Lublin <uril@redhat.com>
|
|
|
|
Previous Spice maintainers were
|
|
|
|
Alon Levy <alevy@redhat.com>
|
|
Gerd Hoffmann <kraxel@redhat.com>
|
|
Izik Eidus <ieidus@redhat.com>
|
|
Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
Yaniv Kamay <ykamay@redhat.com> (Original project author)
|
|
Yonit Halperin <yhalperi@redhat.com>
|
|
|
|
Patches also contributed by
|
|
|
|
Alexander Larsson <alexl@redhat.com>
|
|
Alexander Tsoy <alexander@tsoy.me>
|
|
Andrew Eikum <aeikum@codeweavers.com>
|
|
Aric Stewart <aric@codeweavers.com>
|
|
Arnon Gilboa <agilboa@redhat.com>
|
|
Axel Lin <axel.lin@ingics.com>
|
|
소병철 <byungchul.so@samsung.com>
|
|
Cédric Bosdonnat <cbosdonnat@suse.com>
|
|
Changqing Li <changqing.li@windriver.com>
|
|
Christian Ruppert <idl0r@qasl.de>
|
|
Christophe de Dinechin <dinechin@redhat.com>
|
|
Cole Robinson <crobinso@redhat.com>
|
|
Daniel P. Berrange <berrange@redhat.com>
|
|
Dan Kenigsberg <danken@redhat.com>
|
|
Dan McGee <dpmcgee@gmail.com>
|
|
David Gibson <david@gibson.dropbear.id.au>
|
|
David Jaša <djasa@redhat.com>
|
|
Dunrong Huang <riegamaths@gmail.com>
|
|
Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
|
Erlon Cruz <erlon.cruz@br.flextronics.com>
|
|
Fabiano Fidêncio <fabiano@fidencio.org>
|
|
Francois Gouget <fgouget@codeweavers.com>
|
|
Gal Hammer <ghammer@redhat.com>
|
|
Gilmar Santos Jr <jgasjr@gmail.com>
|
|
Hans de Goede <hdegoede@redhat.com>
|
|
Javier Celaya <javier.celaya@flexvm.es>
|
|
Jeremy White <jwhite@codeweavers.com>
|
|
Jürg Billeter <j@bitron.ch>
|
|
Li Zhijian <lizhijian@cn.fujitsu.com>
|
|
Liang Guo <bluestonechina@gmail.com>
|
|
Lukáš Hrázký <lhrazky@redhat.com>
|
|
Lukas Venhoda <lvenhoda@redhat.com>
|
|
Michal Privoznik <mprivozn@redhat.com>
|
|
Michael Tokarev <mjt@tls.msk.ru>
|
|
Nahum Shalman <nshalman@elys.com>
|
|
Nikolay Orlyuk <virkony@gmail.com>
|
|
Pavel Grunt <pgrunt@redhat.com>
|
|
Peter Robinson <pbrobinson@gmail.com>
|
|
Sandy Stutsman <sstutsma@redhat.com>
|
|
Snir Sheriber <ssheribe@redhat.com>
|
|
Sunny Shin <sunny4s.git@gmail.com>
|
|
Søren Sandmann Pedersen <ssp@redhat.com>
|
|
Thomas Tyminski <thomast@cs.tu-berlin.de>
|
|
Tiziano Mueller <dev-zero@gentoo.org>
|
|
Victor Toso <victortoso@redhat.com>
|
|
Wang Qiang <wangqiang.hunan@gmail.com>
|
|
Yann E. MORIN <yann.morin.1998@free.fr>
|
|
Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
|
|
Douglas Paul <doug@bogon.ca>
|
|
谢 昆明 <kunming.xie@hotmail.com>
|
|
Benjamin Tissoires <benjamin.tissoires@redhat.com>
|
|
Olivier Fourdan <ofourdan@redhat.com>
|
|
worldofpeace <worldofpeace@protonmail.ch>
|
|
Thiago Mendes <tribeirom@gmail.com>
|
|
Christian Ehrhardt <christian.ehrhardt@canonical.com>
|
|
Kevin Pouget <kpouget@redhat.com>
|
|
Rosen Penev <rosenp@gmail.com>
|
|
James Le Cuirot <chewi@gentoo.org>
|
|
Frediano Ziglio <freddy77@gmail.com>
|
|
|
|
....send patches to get your name here...
|