pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-07 18:34:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
cf6e58fe33
spice/server
History
Yonit Halperin cf6e58fe33 red_worker: Fix reference counting for the current frame (drawable) of a stream 
After marshalling MSG_STREAM_CREATE, there is no need to ref and
unref stream->current before and after completing the sending of the
message (correspondingly). The referencing is unnecessary because all
the data that is required from the drawable (the clipping), is copied
during marshalling, and no field in the drawable is referenced (see
spice_marshall_msg_display_stream_create).

Moreover, the referencing was bugous:
While display_channel_hold_pipe_item and
display_channel_client_release_item_after_push referenced and
dereferenced, correspondingly, stream->current, stream->current might
have changed in between these calls, and then we ended up with one drawable
leaking, and one drawable released before its time has come (which
of course led to critical errors).
2012-07-25 14:16:41 +03:00
..
tests tests: add missing file to .gitignore 2012-07-16 17:36:52 +02:00
.gitignore gitignore: add generated_*, vim temps, pyc 2010-11-08 16:06:55 +02:00
agent-msg-filter.c Use the spice-common logging functions 2012-03-25 19:00:00 +02:00
agent-msg-filter.h server: add discard all option to agent message filter 2011-04-04 11:30:30 +02:00
char_device.c char_device: move SpiceCharDeviceState from the header 2012-07-03 14:13:43 +03:00
char_device.h char_device.h: Remove redefinition of typedef 'SpiceCharDeviceState' 2012-07-03 22:29:16 +03:00
demarshallers.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
dispatcher.c Don't do arithmetic on void * type, use uint8_t instead 2012-04-25 09:40:18 +01:00
dispatcher.h server/dispatcher: add dispatcher_register_async_done_callback 2011-11-08 16:22:21 +02:00
glz_encode_match_tmpl.c add #include <config.h> to all source files 2011-05-03 14:44:10 +02:00
glz_encode_tmpl.c Remove trailing whitespace from end of lines 2012-01-13 18:11:59 +02:00
glz_encoder_config.h Fix multiple printf format problems 2012-04-25 09:42:11 +01:00
glz_encoder_dictionary_protected.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
glz_encoder_dictionary.c Remove trailing blank lines 2012-01-13 18:11:59 +02:00
glz_encoder_dictionary.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
glz_encoder.c Remove trailing blank lines 2012-01-13 18:11:59 +02:00
glz_encoder.h Use the spice-common submodule 2012-03-25 18:59:10 +02:00
inputs_channel.c server: handle red_channel_client_create returning NULL 2012-05-21 09:08:50 +03:00
inputs_channel.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
jpeg_encoder.c Use the spice-common logging functions 2012-03-25 19:00:00 +02:00
jpeg_encoder.h Remove trailing whitespace from end of lines 2012-01-13 18:11:59 +02:00
main_channel.c agent: use SpiceCharDeviceWriteBuffer for agent data from the client 2012-07-03 14:13:41 +03:00
main_channel.h agent: employ SpiceCharDeviceState for managing reading from the device 2012-07-03 14:13:41 +03:00
main_dispatcher.c server, separate SpiceChannelEventInfo from RedStream 2012-02-15 15:04:04 +02:00
main_dispatcher.h [0.8 branch] server: add main_dispatcher 2011-10-31 17:35:54 +02:00
Makefile.am char_device: Introducing shared flow control code for char devices. 2012-07-03 14:13:41 +03:00
mjpeg_encoder.c server/mjpeg_encoder: realloc encoder->row, when a wider frame is given 2012-05-16 08:55:11 +03:00
mjpeg_encoder.h server/mjpeg_encoder: Fix memory leak for the inital output buffer given for each frame 2012-05-10 14:01:04 +03:00
red_bitmap_utils.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
red_channel.c server/red_channel: s/channle/channel 2012-06-07 12:26:05 +03:00
red_channel.h server/red_channel: fix possible access to released channel clients 2012-05-31 09:39:14 +03:00
red_client_cache.h Use the spice-common logging functions 2012-03-25 19:00:00 +02:00
red_client_shared_cache.h Use the spice-common logging functions 2012-03-25 19:00:00 +02:00
red_common.h server: factor out bitmap_fmt_is_rgb 2012-07-22 11:58:36 +03:00
red_dispatcher.c server: add monitors_config support 2012-07-22 13:50:49 +03:00
red_dispatcher.h server: add monitors_config support 2012-07-22 13:50:49 +03:00
red_memslots.c server: allow failure in getvirt 2012-04-05 18:28:49 +03:00
red_memslots.h server: allow failure in getvirt 2012-04-05 18:28:49 +03:00
red_parse_qxl.c server/red_parse_qxl: red_get_image: fix leaks on bad image 2012-07-22 13:50:16 +03:00
red_parse_qxl.h server: move self_bitmap_image to RedDrawable 2012-05-15 18:01:54 +03:00
red_tunnel_worker.c server: handle red_channel_client_create returning NULL 2012-05-21 09:08:50 +03:00
red_tunnel_worker.h server: Unset executable bit of red_tunnel_worker.h 2011-05-05 20:04:49 +03:00
red_worker.c red_worker: Fix reference counting for the current frame (drawable) of a stream 2012-07-25 14:16:41 +03:00
red_worker.h server: add monitors_config support 2012-07-22 13:50:49 +03:00
reds_gl_canvas.c Use the spice-common submodule 2012-03-25 18:59:10 +02:00
reds_gl_canvas.h Use the spice-common submodule 2012-03-25 18:59:10 +02:00
reds_sw_canvas.c Use the spice-common submodule 2012-03-25 18:59:10 +02:00
reds_sw_canvas.h Use the spice-common submodule 2012-03-25 18:59:10 +02:00
reds.c server/reds: more fixes for wrong spice_error in d2c99b59 2012-07-22 13:34:11 +03:00
reds.h agent: use SpiceCharDeviceWriteBuffer for agent data from the client 2012-07-03 14:13:41 +03:00
smartcard.c smartcard: Remove redefinition of typedef 'SmartCardDeviceState' 2012-07-04 11:16:01 +03:00
smartcard.h smartcard: use SpiceCharDeviceState for managing reading from the device 2012-07-03 14:13:42 +03:00
snd_worker.c server: handle red_channel_client_create returning NULL 2012-05-21 09:08:50 +03:00
snd_worker.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
spice-experimental.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
spice-server.syms server: add monitors_config support 2012-07-22 13:50:49 +03:00
spice.h bump version to 0.11.1 for new spice_qxl_monitors_config_async 2012-07-23 15:46:53 +03:00
spicevmc.c spicevmc: use SpiceCharDeviceState for writing to the guest device 2012-07-03 14:13:42 +03:00
stat.h Remove trailing blank lines 2012-01-13 18:11:59 +02:00
zlib_encoder.c Use the spice-common logging functions 2012-03-25 19:00:00 +02:00
zlib_encoder.h applying zlib compression over glz on WAN connection 2010-06-21 15:05:37 +02:00