mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice
synced 2025-12-26 14:41:25 +00:00
48ab22b728
Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
because of this error/warning:
> gstreamer-encoder.c: In function 'set_video_bit_rate':
> gstreamer-encoder.c:518:17: error: taking the absolute value of
> unsigned type 'uint64_t' {aka 'long unsigned int'} has no effect
> [-Werror=absolute-value]
> 518 | } else if (abs(bit_rate - encoder->video_bit_rate) > encoder->video_bit_rate * SPICE_GST_VIDEO_BITRATE_MARGIN) {
> | ^~~
> gstreamer-encoder.c:518:17: error: absolute value function 'abs'
> given an argument of type 'uint64_t' {aka 'long unsigned int'}
This patches solves these two warnings:
1) cast the substraction to a signed type (int64_t instead of
uint64_t) to preserve the operation meaning;
2) use a custom version of abs() to avoid data truncation and/or
platform-dependent type lengths (abs/labs/llabs)
Acked-by: Frediano Ziglio <fziglio@redhat.com>
84 lines
2.6 KiB
C
84 lines
2.6 KiB
C
/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */
|
|
/*
|
|
Copyright (C) 2009-2015 Red Hat, Inc.
|
|
|
|
This library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
This library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef UTILS_H_
|
|
#define UTILS_H_
|
|
|
|
#include <stdint.h>
|
|
#include <glib.h>
|
|
|
|
#define SPICE_GNUC_VISIBLE __attribute__ ((visibility ("default")))
|
|
|
|
static inline void set_bit(int index, uint32_t *addr)
|
|
{
|
|
uint32_t mask = 1 << index;
|
|
__sync_or_and_fetch(addr, mask);
|
|
}
|
|
|
|
static inline void clear_bit(int index, uint32_t *addr)
|
|
{
|
|
uint32_t mask = ~(1 << index);
|
|
__sync_and_and_fetch(addr, mask);
|
|
}
|
|
|
|
static inline int test_bit(int index, uint32_t val)
|
|
{
|
|
return val & (1u << index);
|
|
}
|
|
/* a generic safe for loop macro */
|
|
#define SAFE_FOREACH(link, next, cond, ring, data, get_data) \
|
|
for ((((link) = ((cond) ? ring_get_head(ring) : NULL)), \
|
|
((next) = ((link) ? ring_next((ring), (link)) : NULL)), \
|
|
((data) = ((link)? (get_data) : NULL))); \
|
|
(link); \
|
|
(((link) = (next)), \
|
|
((next) = ((link) ? ring_next((ring), (link)) : NULL)), \
|
|
((data) = ((link)? (get_data) : NULL))))
|
|
|
|
typedef int64_t red_time_t;
|
|
|
|
#define NSEC_PER_SEC INT64_C(1000000000)
|
|
#define NSEC_PER_MILLISEC INT64_C(1000000)
|
|
#define NSEC_PER_MICROSEC INT64_C(1000)
|
|
|
|
/* g_get_monotonic_time() does not have enough precision */
|
|
static inline red_time_t spice_get_monotonic_time_ns(void)
|
|
{
|
|
struct timespec time;
|
|
|
|
clock_gettime(CLOCK_MONOTONIC, &time);
|
|
return NSEC_PER_SEC * time.tv_sec + time.tv_nsec;
|
|
}
|
|
|
|
#define MSEC_PER_SEC 1000
|
|
|
|
int rgb32_data_has_alpha(int width, int height, size_t stride,
|
|
const uint8_t *data, int *all_set_out);
|
|
|
|
const char *red_channel_type_to_str(int type);
|
|
int red_channel_name_to_type(const char *name);
|
|
|
|
void red_dump_openssl_errors(void);
|
|
|
|
static inline int64_t i64abs(int64_t value)
|
|
{
|
|
return (value >= 0) ? value : -value;
|
|
}
|
|
|
|
#endif /* UTILS_H_ */
|