mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice
synced 2026-01-08 21:14:11 +00:00
A few dispose/finalize implementations were not chaining up to their parent classes, causing memory leaks. This fixes leaks like the following: ==16240== Memcheck, a memory error detector ==16240== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al. ==16240== Using Valgrind-3.12.0 and LibVEX; rerun with -h for copyright info ==16240== Command: ./test-leaks ==16240== ==16240== ==16240== HEAP SUMMARY: ==16240== in use at exit: 245,490 bytes in 3,638 blocks ==16240== total heap usage: 5,418 allocs, 1,780 frees, 17,676,968 bytes allocated ==16240== ==16240== 16 bytes in 1 blocks are definitely lost in loss record 203 of 771 ==16240== at 0x4C2DADE: malloc (vg_replace_malloc.c:298) ==16240== by 0x4C2FC91: realloc (vg_replace_malloc.c:785) ==16240== by 0x52864E: dispatcher_register_handler (dispatcher.c:374) ==16240== by 0x5293E0: main_dispatcher_constructed (main-dispatcher.c:315) ==16240== by 0x7F873DB: g_object_new_internal (gobject.c:1823) ==16240== by 0x7F87EE4: g_object_new_valist (gobject.c:2042) ==16240== by 0x7F86E90: g_object_new (gobject.c:1626) ==16240== by 0x5292A5: main_dispatcher_new (main-dispatcher.c:295) ==16240== by 0x429A0A: do_spice_init (reds.c:3416) ==16240== by 0x42A3F5: spice_server_init (reds.c:3663) ==16240== by 0x4095B1: server_leaks (test-leaks.c:45) ==16240== by 0x844C60A: test_case_run (gtestutils.c:2161) ==16240== by 0x844C9CA: g_test_run_suite_internal (gtestutils.c:2244) ==16240== by 0x844CA73: g_test_run_suite_internal (gtestutils.c:2256) ==16240== by 0x844CC8A: g_test_run_suite (gtestutils.c:2332) ==16240== by 0x844B92C: g_test_run (gtestutils.c:1599) ==16240== by 0x409A0B: main (test-leaks.c:126) ==16240== ==16240== 16 bytes in 1 blocks are definitely lost in loss record 204 of 771 ==16240== at 0x4C2DADE: malloc (vg_replace_malloc.c:298) ==16240== by 0x4C2FC91: realloc (vg_replace_malloc.c:785) ==16240== by 0x52864E: dispatcher_register_handler (dispatcher.c:374) ==16240== by 0x5293E0: main_dispatcher_constructed (main-dispatcher.c:315) ==16240== by 0x7F873DB: g_object_new_internal (gobject.c:1823) ==16240== by 0x7F87EE4: g_object_new_valist (gobject.c:2042) ==16240== by 0x7F86E90: g_object_new (gobject.c:1626) ==16240== by 0x5292A5: main_dispatcher_new (main-dispatcher.c:295) ==16240== by 0x429A0A: do_spice_init (reds.c:3416) ==16240== by 0x42A3F5: spice_server_init (reds.c:3663) ==16240== by 0x40BFD4: test_new (test-display-base.c:902) ==16240== by 0x40979D: vmc_leaks (test-leaks.c:92) ==16240== by 0x844C60A: test_case_run (gtestutils.c:2161) ==16240== by 0x844C9CA: g_test_run_suite_internal (gtestutils.c:2244) ==16240== by 0x844CA73: g_test_run_suite_internal (gtestutils.c:2256) ==16240== by 0x844CC8A: g_test_run_suite (gtestutils.c:2332) ==16240== by 0x844B92C: g_test_run (gtestutils.c:1599) ==16240== by 0x409A0B: main (test-leaks.c:126) ==16240== ==16240== 96 bytes in 1 blocks are definitely lost in loss record 638 of 771 ==16240== at 0x4C2FA50: calloc (vg_replace_malloc.c:711) ==16240== by 0x8427D3C: g_malloc0 (gmem.c:124) ==16240== by 0x842801F: g_malloc0_n (gmem.c:355) ==16240== by 0x527B44: dispatcher_constructed (dispatcher.c:141) ==16240== by 0x529321: main_dispatcher_constructed (main-dispatcher.c:307) ==16240== by 0x7F873DB: g_object_new_internal (gobject.c:1823) ==16240== by 0x7F87EE4: g_object_new_valist (gobject.c:2042) ==16240== by 0x7F86E90: g_object_new (gobject.c:1626) ==16240== by 0x5292A5: main_dispatcher_new (main-dispatcher.c:295) ==16240== by 0x429A0A: do_spice_init (reds.c:3416) ==16240== by 0x42A3F5: spice_server_init (reds.c:3663) ==16240== by 0x4095B1: server_leaks (test-leaks.c:45) ==16240== by 0x844C60A: test_case_run (gtestutils.c:2161) ==16240== by 0x844C9CA: g_test_run_suite_internal (gtestutils.c:2244) ==16240== by 0x844CA73: g_test_run_suite_internal (gtestutils.c:2256) ==16240== by 0x844CC8A: g_test_run_suite (gtestutils.c:2332) ==16240== by 0x844B92C: g_test_run (gtestutils.c:1599) ==16240== by 0x409A0B: main (test-leaks.c:126) ==16240== ==16240== 96 bytes in 1 blocks are definitely lost in loss record 639 of 771 ==16240== at 0x4C2FA50: calloc (vg_replace_malloc.c:711) ==16240== by 0x8427D3C: g_malloc0 (gmem.c:124) ==16240== by 0x842801F: g_malloc0_n (gmem.c:355) ==16240== by 0x527B44: dispatcher_constructed (dispatcher.c:141) ==16240== by 0x529321: main_dispatcher_constructed (main-dispatcher.c:307) ==16240== by 0x7F873DB: g_object_new_internal (gobject.c:1823) ==16240== by 0x7F87EE4: g_object_new_valist (gobject.c:2042) ==16240== by 0x7F86E90: g_object_new (gobject.c:1626) ==16240== by 0x5292A5: main_dispatcher_new (main-dispatcher.c:295) ==16240== by 0x429A0A: do_spice_init (reds.c:3416) ==16240== by 0x42A3F5: spice_server_init (reds.c:3663) ==16240== by 0x40BFD4: test_new (test-display-base.c:902) ==16240== by 0x40979D: vmc_leaks (test-leaks.c:92) ==16240== by 0x844C60A: test_case_run (gtestutils.c:2161) ==16240== by 0x844C9CA: g_test_run_suite_internal (gtestutils.c:2244) ==16240== by 0x844CA73: g_test_run_suite_internal (gtestutils.c:2256) ==16240== by 0x844CC8A: g_test_run_suite (gtestutils.c:2332) ==16240== by 0x844B92C: g_test_run (gtestutils.c:1599) ==16240== by 0x409A0B: main (test-leaks.c:126) ==16240== ==16240== LEAK SUMMARY: ==16240== definitely lost: 224 bytes in 4 blocks ==16240== indirectly lost: 0 bytes in 0 blocks ==16240== possibly lost: 0 bytes in 0 blocks ==16240== still reachable: 207,718 bytes in 3,312 blocks ==16240== of which reachable via heuristic: ==16240== newarray : 1,536 bytes in 16 blocks ==16240== suppressed: 34,548 bytes in 302 blocks ==16240== Reachable blocks (those to which a pointer was found) are not shown. ==16240== To see them, rerun with: --leak-check=full --show-leak-kinds=all ==16240== ==16240== For counts of detected and suppressed errors, rerun with: -v ==16240== ERROR SUMMARY: 4 errors from 4 contexts (suppressed: 20 from 20) FAIL test-leaks (exit status: 1) Acked-by: Frediano Ziglio <fziglio@redhat.com> |
||
|---|---|---|
| build-aux | ||
| docs | ||
| m4 | ||
| server | ||
| spice-common@6439bec0de | ||
| tests | ||
| tools | ||
| uncrustify_cfg | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| .mailmap | ||
| .travis.yml | ||
| AUTHORS | ||
| autogen.sh | ||
| cfg.mk | ||
| ChangeLog | ||
| configure.ac | ||
| COPYING | ||
| GNUmakefile | ||
| maint.mk | ||
| Makefile.am | ||
| NEWS | ||
| README | ||
| spice-server.pc.in | ||
| TODO.multiclient | ||
SPICE: Simple Protocol for Independent Computing Environments
=============================================================
SPICE is a remote display system built for virtual environments which
allows you to view a computing 'desktop' environment not only on the
machine where it is running, but from anywhere on the Internet and
from a wide variety of machine architectures.
Installation
------------
The SPICE package uses GNU autotools, so the build install process
follows the standard process documented in the INSTALL file. As a
quick start you can do
./configure --prefix=/usr --sysconfdir=/etc \
--localstatedir=/var --libdir=/usr/lib
make
sudo make install
Or to install into a private user specific location
./configure --prefix=$HOME/spice
make
make install
The following mandatory dependancies are required in order to
build SPICE
Spice protocol >= 0.9.0
Pixman >= 0.17.7
OpenSSL
libjpeg
zlib
Cyrus-SASL
The following optional dependancies increase the available
functionality
GE Gui >= 0.6.0, < 0.7.0 (GUI app support)
OpenGL (GUI app support)
Alsa (Linux support)
XRandR >= 1.2 (X11 support)
Xinerama >= 1.0 (X11 support)
libcacard >= 0.1.2 (Smartcard support)
Communication
-------------
To communicate with the development team, or to post patches
there is a technical mailing list:
http://lists.freedesktop.org/mailman/listinfo/spice-devel
There is also a mailing list for new release announcements:
http://lists.freedesktop.org/archives/spice-announce/
To view known bugs, or report new bugs, in SPICE visit
https://bugs.freedesktop.org/describecomponents.cgi?product=Spice
Bugs found when using an OS distribution's binary packages should
be reported to the OS vendors' own bug tracker first.
The latest SPICE code can be found in GIT at:
http://cgit.freedesktop.org/spice/
Licensing
---------
SPICE is provided under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
Please see the COPYING file for the complete LGPLv2+ license
terms, or visit <http://www.gnu.org/licenses/>.
Experimental Features
---------------------
To enable multiple client connections, set:
SPICE_DEBUG_ALLOW_MC=1
-- End of readme