pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-01-06 19:05:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,927 Commits 29 Branches 62 Tags 9.6 MiB
C++ 62%
C 28.6%
Makefile 4%
M4 3%
Meson 0.9%
Other 1.5%
48179332d9
Go to file
Christophe Fergeau 48179332d9 dcc: Fix QUIC fallback in get_compression_for_bitmap() 
There was a small regression introduced in get_compression_for_bitmap()
by f401eb07f dcc: Rewrite dcc_image_compress.
If SPICE_IMAGE_COMPRESSION_AUTO_GLZ is specified, and the bitmap has a
stride which is bigger than its width (ie it has padding), then
get_compression_for_bitmap() will return SPICE_IMAGE_COMPRESSION_OFF
while in that case, we used to use QUIC for compression.

This happens because that function in the AUTO_GLZ case first checks if
QUIC should be used, if not, it decides to use GLZ, but then decides it
can't because of the stride, so falls back to OFF, while it used to
fall back to QUIC.

This commit only slightly reworks a preexisting if (!can_lz_compress())
check so that it's unconditional rather than depending on the previous
checks having been unsuccessful.

This issue could be observed by using a spice-html5 without support for
uncompressed bitmaps with end-of-line padding by simply starting a f28
VM and connecting to it/moving the mouse cursor in it.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
2018-07-20 12:36:19 +01:00
build-aux Update git-version-gen to latest version 2013-12-11 16:32:36 +01:00
docs docs: Update links in README and manual 2018-05-10 16:59:35 +03:00
m4 build-sys: Do not abort on warnings 2017-04-22 08:44:21 +01:00
server dcc: Fix QUIC fallback in get_compression_for_bitmap() 2018-07-20 12:36:19 +01:00
spice-common@f82a6c5349 Rename SpiceHead::id to monitor_id in the protocol 2018-07-18 08:17:13 +01:00
tests tests/migrate.py: add --vdagent 2011-08-23 17:01:14 +03:00
tools reds_stat: Show single spice file if only one is present 2017-09-14 16:36:14 +01:00
uncrustify_cfg fresh start 2009-10-14 15:06:41 +02:00
.gitignore docs: Add some documentation on spice threading model 2017-09-11 18:03:57 +01:00
.gitlab-ci.yml ci: Run an additional make check using Centos 2018-07-11 10:21:26 +01:00
.gitmodules spice-common submodule: update url (add .git at the end) 2018-06-20 14:08:35 +01:00
.mailmap syntax-check: Fix missing AUTHORS 2016-12-05 13:48:28 +00:00
.travis.yml Add travis CI file 2015-11-27 20:21:24 +01:00
AUTHORS syntax-check: Add missing contributors names to AUTHORS 2018-04-06 08:30:01 +01:00
autogen.sh build-sys: Pass --enable-python-checks when running autogen.sh 2015-04-23 10:38:24 +02:00
cfg.mk build-sys: Add make check-valgrind target 2017-03-21 16:34:56 +01:00
ChangeLog fresh start 2009-10-14 15:06:41 +02:00
configure.ac build: Use SPICE_CHECK_CELT051 in configure.ac 2018-06-20 13:55:16 +01:00
COPYING Relicense everything from GPL to LGPL 2.1+ 2010-04-13 22:22:15 +02:00
GNUmakefile syntax-check: Update gnufiles 2016-11-18 12:06:53 +00:00
maint.mk syntax-check: Update gnufiles 2016-11-18 12:06:53 +00:00
Makefile.am build: Remove unsupported --enable-automated-tests option on make distcheck 2018-06-18 16:28:33 +01:00
NEWS spice-server 0.14.0 release 2017-10-11 10:36:34 +02:00
README README: Update required spice protocol version 2018-06-05 09:39:22 +01:00
spice-server.pc.in build-sys: Require a new enough spice-protocol in .pc file 2015-08-26 11:01:09 +02:00
TODO.multiclient Remove trailing whitespace from end of lines 2012-01-13 18:11:59 +02:00

README 

   SPICE: Simple Protocol for Independent Computing Environments
   =============================================================

SPICE is a remote display system built for virtual environments which
allows you to view a computing 'desktop' environment not only on the
machine where it is running, but from anywhere on the Internet and
from a wide variety of machine architectures.

Installation
------------

The SPICE package uses GNU autotools, so the build install process
follows the standard process documented in the INSTALL file. As a
quick start you can do

  ./configure --prefix=/usr --sysconfdir=/etc \
        --localstatedir=/var --libdir=/usr/lib
  make
  sudo make install

Or to install into a private user specific location

  ./configure --prefix=$HOME/spice
  make
  make install

The following mandatory dependencies are required in order to
build SPICE

    Spice protocol >= 0.12.14
    Pixman         >= 0.17.7
    OpenSSL
    libjpeg
    zlib

The following optional dependencies increase the available
functionality

    Cyrus-SASL
    libcacard      >= 0.1.2             (Smartcard support)
    Opus           >= 1.0.0             (Opus audio encoding support)
    LZ4                                 (LZ4 compression support)
    GStreamer      >= 1.0.0

Communication
-------------

To communicate with the development team, or to post patches
there is a technical mailing list:

   http://lists.freedesktop.org/mailman/listinfo/spice-devel

There is also a mailing list for new release announcements:

   http://lists.freedesktop.org/archives/spice-announce/

To view known bugs, or report new bugs, in SPICE visit

   https://bugs.freedesktop.org/describecomponents.cgi?product=Spice

Bugs found when using an OS distribution's binary packages should
be reported to the OS vendors' own bug tracker first.

The latest SPICE code can be found in GIT at:

   https://gitlab.freedesktop.org/spice/

Licensing
---------

SPICE is provided under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.

Please see the COPYING file for the complete LGPLv2+ license
terms, or visit <http://www.gnu.org/licenses/>.

Experimental Features
---------------------
To enable multiple client connections, set:
SPICE_DEBUG_ALLOW_MC=1

-- End of readme