mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice
synced 2025-12-26 14:41:25 +00:00
15b1e2a3bb
When SASL is active, if a read request is made and SASL buffer contains some data (but not enough to fulfill the request), upon return the taken data from the buffer is not accounted for and hence part of the message gets discarded. red_stream_sasl_read function takes available data from sasl buffer and returns if it's enough. If it's not, nbyte is decremented and buf pointer is incremented to account for the taken data (if any). Then it tries to get more data from the socket and decode it. Suppose there was some data in the sasl buffer, but not enough. Then the socket is not readable (EAGAIN, EINTR, whatever) or the new data isn't enough for sasl_decode (hence decodedlen == 0). In both cases the function returns as if no data was read, but it took some data from sasl buffer. This data is lost and from this point on the communication ceases on the channel (eventually new data is read, but messages are corrupt without the parts previously discarded). On the other hand, if some data is read from sasl buffer and everything else works fine, the output buffer contains all the data, but the count returned only inform the caller about the newly read data (which causes the similar effect of discarding part of the message). Fixes: https://gitlab.freedesktop.org/spice/spice/-/issues/40 Acked-by: Frediano Ziglio <fziglio@redhat.com> |
||
|---|---|---|
| build-aux | ||
| docs | ||
| m4 | ||
| server | ||
| subprojects | ||
| tests | ||
| tools | ||
| uncrustify_cfg | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| .mailmap | ||
| .travis.yml | ||
| AUTHORS | ||
| autogen.sh | ||
| cfg.mk | ||
| CHANGELOG.md | ||
| configure.ac | ||
| COPYING | ||
| GNUmakefile | ||
| maint.mk | ||
| Makefile.am | ||
| meson_options.txt | ||
| meson.build | ||
| README | ||
| README.Windows.md | ||
| spice-server.pc.in | ||
| TODO.multiclient | ||
SPICE: Simple Protocol for Independent Computing Environments
=============================================================
SPICE is a remote display system built for virtual environments which
allows you to view a computing 'desktop' environment not only on the
machine where it is running, but from anywhere on the Internet and
from a wide variety of machine architectures.
Installation
------------
The SPICE package uses GNU autotools, so the build install process
follows the standard process documented in the INSTALL file. As a
quick start you can do
./configure --prefix=/usr --sysconfdir=/etc \
--localstatedir=/var --libdir=/usr/lib
make
sudo make install
Or to install into a private user specific location
./configure --prefix=$HOME/spice
make
make install
The following mandatory dependencies are required in order to
build SPICE
Spice protocol >= 0.14.0
Pixman >= 0.17.7
OpenSSL
libjpeg
zlib
The following optional dependencies increase the available
functionality
Cyrus-SASL
libcacard >= 2.5.1 (Smartcard support)
Opus >= 1.0.0 (Opus audio encoding support)
LZ4 (LZ4 compression support)
GStreamer >= 1.0.0
Communication
-------------
To communicate with the development team, or to post patches
there is a technical mailing list:
http://lists.freedesktop.org/mailman/listinfo/spice-devel
There is also a mailing list for new release announcements:
http://lists.freedesktop.org/archives/spice-announce/
To view known bugs, or report new bugs, in SPICE visit
https://gitlab.freedesktop.org/spice/spice/issues/new?
Bugs found when using an OS distribution's binary packages should
be reported to the OS vendors' own bug tracker first.
The latest SPICE code can be found in GIT at:
https://gitlab.freedesktop.org/spice/
Licensing
---------
SPICE is provided under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
Please see the COPYING file for the complete LGPLv2+ license
terms, or visit <http://www.gnu.org/licenses/>.
Experimental Features
---------------------
To enable multiple client connections, set:
SPICE_DEBUG_ALLOW_MC=1
-- End of readme