mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice
synced 2025-12-26 14:41:25 +00:00
0df59fcfc9
AgentMsgFilter needs to know whether monitors config messages need to be
filtered or not. This used to be done from within
agent_msg_filter_config() using the global RedsState, but this got more
tricky as it was removed.
A first attempt a1e62fa5ae caused crashes on qemu startup with
"qemu-system-x86_64 -spice port=5900" (without -vga qxl). A second
attempt added a RedsState* argument to agent_msg_filter_config() which
in my opinion is not really nice from a layering point of view.
This new attempt makes sure AgentMsgFilter state is correct when the
filter is set to stop discarding all data, which allows to remove direct
use of RedsState from within AgentMsgFilter.
Acked-by: Frediano Ziglio <fziglio@redhat.com>
125 lines
4.1 KiB
C
125 lines
4.1 KiB
C
/*
|
|
Copyright (C) 2011 Red Hat, Inc.
|
|
|
|
This library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
This library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
Red Hat Authors:
|
|
hdegoede@redhat.com
|
|
*/
|
|
#ifdef HAVE_CONFIG_H
|
|
#include <config.h>
|
|
#endif
|
|
|
|
#include <string.h>
|
|
#include "red-common.h"
|
|
#include "agent-msg-filter.h"
|
|
#include "reds.h"
|
|
#include "red-qxl.h"
|
|
|
|
void agent_msg_filter_config(struct AgentMsgFilter *filter,
|
|
gboolean copy_paste, gboolean file_xfer,
|
|
gboolean use_client_monitors_config)
|
|
{
|
|
filter->copy_paste_enabled = copy_paste;
|
|
filter->file_xfer_enabled = file_xfer;
|
|
filter->use_client_monitors_config = use_client_monitors_config;
|
|
}
|
|
|
|
void agent_msg_filter_init(struct AgentMsgFilter *filter,
|
|
gboolean copy_paste, gboolean file_xfer,
|
|
gboolean use_client_monitors_config,
|
|
int discard_all)
|
|
{
|
|
memset(filter, 0, sizeof(*filter));
|
|
agent_msg_filter_config(filter, copy_paste, file_xfer,
|
|
use_client_monitors_config);
|
|
filter->discard_all = discard_all;
|
|
}
|
|
|
|
int agent_msg_filter_process_data(struct AgentMsgFilter *filter,
|
|
uint8_t *data, uint32_t len)
|
|
{
|
|
struct VDAgentMessage msg_header;
|
|
|
|
if (len > VD_AGENT_MAX_DATA_SIZE) {
|
|
spice_printerr("invalid agent message: too large");
|
|
return AGENT_MSG_FILTER_PROTO_ERROR;
|
|
}
|
|
|
|
/* Are we expecting more data from a previous message? */
|
|
if (filter->msg_data_to_read) {
|
|
data_to_read:
|
|
if (len > filter->msg_data_to_read) {
|
|
spice_printerr("invalid agent message: data exceeds size from header");
|
|
return AGENT_MSG_FILTER_PROTO_ERROR;
|
|
}
|
|
filter->msg_data_to_read -= len;
|
|
return filter->result;
|
|
}
|
|
|
|
if (len < sizeof(msg_header)) {
|
|
spice_printerr("invalid agent message: incomplete header");
|
|
return AGENT_MSG_FILTER_PROTO_ERROR;
|
|
}
|
|
memcpy(&msg_header, data, sizeof(msg_header));
|
|
len -= sizeof(msg_header);
|
|
|
|
if (msg_header.protocol != VD_AGENT_PROTOCOL) {
|
|
spice_printerr("invalid agent protocol: %u", msg_header.protocol);
|
|
return AGENT_MSG_FILTER_PROTO_ERROR;
|
|
}
|
|
|
|
if (filter->discard_all) {
|
|
filter->result = AGENT_MSG_FILTER_DISCARD;
|
|
} else {
|
|
switch (msg_header.type) {
|
|
case VD_AGENT_CLIPBOARD:
|
|
case VD_AGENT_CLIPBOARD_GRAB:
|
|
case VD_AGENT_CLIPBOARD_REQUEST:
|
|
case VD_AGENT_CLIPBOARD_RELEASE:
|
|
if (filter->copy_paste_enabled) {
|
|
filter->result = AGENT_MSG_FILTER_OK;
|
|
} else {
|
|
filter->result = AGENT_MSG_FILTER_DISCARD;
|
|
}
|
|
break;
|
|
case VD_AGENT_FILE_XFER_START:
|
|
case VD_AGENT_FILE_XFER_STATUS:
|
|
case VD_AGENT_FILE_XFER_DATA:
|
|
if (filter->file_xfer_enabled) {
|
|
filter->result = AGENT_MSG_FILTER_OK;
|
|
} else {
|
|
filter->result = AGENT_MSG_FILTER_DISCARD;
|
|
}
|
|
break;
|
|
case VD_AGENT_MONITORS_CONFIG:
|
|
if (filter->use_client_monitors_config) {
|
|
filter->result = AGENT_MSG_FILTER_MONITORS_CONFIG;
|
|
} else {
|
|
filter->result = AGENT_MSG_FILTER_OK;
|
|
}
|
|
break;
|
|
default:
|
|
filter->result = AGENT_MSG_FILTER_OK;
|
|
}
|
|
}
|
|
|
|
filter->msg_data_to_read = msg_header.size;
|
|
if (filter->msg_data_to_read) {
|
|
goto data_to_read;
|
|
}
|
|
|
|
return filter->result;
|
|
}
|