pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-26 14:41:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
4,808 Commits 29 Branches 62 Tags 9.6 MiB
force-initial-frame-encode
Commit Graph

4808 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Frediano Ziglio
bf04d7d721 utils: Very skinny share_ptr implementation for our references 
It will be used to refactor reference counting code.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
54c0830919 input-channels: Improve encapsulation 
Update member access to limit it.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
b28db35af5 reds: Make mig_wait_disconnect_clients a std::forward_list 
In the meanwhile remove a leak on the program.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
9dcf937767 reds: Move qxl_instances to red::safe_list 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
454b18fcae char-device: Convert some static functions to methods 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
1411383483 char-device: Automatically convert functions to methods 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
5f7aaf2a9a char-device: Remove define trick, won't work on C++ 
C++ check parameter type, not founding the functions at
link time.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
26e6d15551 char-device: Prepare to move functions to methods 
Move structure declaration at the end.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
2b11c917dc Do not use GError to just return an error string 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
4233df686e reds: Move clients to safe_list 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
ec66702526 reds: Use red::safe_list instead of GList 
Use an utility list.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
767a9caded Allow to compile without C++ library 
Provide a suitable allocator using GLib

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
fe0298a290 safe-list: Add a class to implement a list with safe iterators 
The reason to not using STL is that our code from how was designed requires
the iterator to be safe to the delete of the element pointed by the iterator.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
350646608d red-channel: Small simplification 
Use std::max to make code smaller

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
ab7486a9e8 main-channel-client: Automatically convert 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
9fd105e925 main-channel: Automatic convert functions to methods 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
fef97b14e5 red-client: Make RedClient pure C++ 
Remove GObject.
Add access protection.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
cc86a7fb53 red-client: Automatically convert functions to methods 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
43c6bf91b7 reds: Remove a weak pointer usage 
RedCharDevice can all be removed just calling unref, beside
the agent that needs special threatment.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
f4aefa728e Remove GObject from Dispatcher hierarchy 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
f680cc7870 dispatcher: Add a more safe dispatcher_send_message_custom version 
Use a template to wrap the other dispatcher_send_message_custom
avoiding having to pass a void* opaque and extract payload size
from passed type.
Will be used more by next commit when Dispatchers are turned into
C++.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
164a333f99 Define and use (un)ref 
Avoids g_object_(un)ref.
This in preparation to remove GObject.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
75679dc95d dispatcher: Use IS-A relationship for Dispatcher hierarchy 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
ea0d056bb7 char-device: Define and use (un)ref 
Prepare to remove GObject.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
9e5781e81c char-device: Do not use signals just to call our routine 
The only notify was done from the same file.
All other read of the property were replaced.
Preparing to remove GObject.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
13f27ab8e9 sound: Make on_message_done a virtual function 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
16f89a80fa inputs-channel: Move some methods to protected 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
4372c0a3ff inputs-channels-client: Call pipe_add_init from InputsChannelClient::init 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
411cb26301 main-channel: Remove some casts 
Add MainChannelClient::get_channel to avoid to manually cast
to derived type.
Pass objects as MainChannelClient instead of RedChannelClient if
we need a MainChannelClient.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
2d865a78da red-channel-client: Make start_connectivity_monitoring protected 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
aecbdd9e5b red-channel-client: Make handle_message protected 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
9ae11a3545 red-channel-client: Move some methods to a protected section 
Reduce visibility and increase encapsulation.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
f42a20c508 Improve CommonGraphicsChannel encapsulation 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
2bf72a5ce2 stream-channel: More incapsulation for StreamChannel 
Put all functions into methods.
Separate public/private part.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
6444fd6cfe inputs-channel: More C++ on InputsChannel 
Removed ugly converts putting in InputsChannelClient::get_channel().
Removed silly accessors.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
9df07e3f20 inputs-channel: Make InputsChannel more encapsulated 
Put functions into methods.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
104aa6e1af Remove GObject from RedChannel 
The patch seems pretty huge but mainly are mechanical steps:
- remove GObject declarations
- do not inherit from GObject
- add SPICE_CXX_GLIB_ALLOCATOR to avoid using C++ allocators
- CLASS_init and CLASS_constructor code goes into C++ constructor
- CLASS_dispose and CLASS_finalize code goes into C++ destructor
- g_object_new is replaced by new operator
- class members goes into virtual methods
- class parameters became argument to constructor
- use push-visibility.h and pop-visibility.h to limit visibility
- temporary use XXX_CAST for old GObject casts, they will
  be replaced
- g_object_get is replaced by accessors

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
3136a11f39 cursor-channel-client: Use covariance to avoid some casts 
CursorChannelClient knows that the channel is a CursorChannel.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
0807ccea59 cursor-channel-client: Move all public functions to methods 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
435ea33540 Reduce C++ symbols visibility 
This allows the compiler to do some more optimisations on the
produced binary.
To allows possible future portability include header/footer in
some helper header files.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
bd4b1caeb8 Use template to make adding timers/watches safer 
Instead of forcibly cast functions cast only if data pointer and
function pointers match. This also allows to remove dangerous
casts all over the place.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
fdedbe9e94 dcc-send: Avoid to call DISPLAY_CHANNEL_CLIENT to cast 
It's useless now, it's always a DisplayChannelClient, pass the
right type.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
cf51158811 red-channel-client: Move handle_migrate_data_get_serial as a virtual function 
Virtual functions cannot be null so use a return value instead
and return the serial using a reference.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
d5ea93d3a8 Make disconnect a virtual function 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
70367fd460 red-channel-client: Move handle_migrate_flush_mark as a virtual function 
Note that the return value was removed as not used.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
28a4fc5a10 red-channel-client: Move migrate as virtual method 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
2b04f644f6 red-channel-client: Move handle_migrate_data as virtual function 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
2ffa7d00c6 inputs-channel-client: Improve encapsulation for InputsChannelClient 
Move most inputs_channel_client_* functions inside the class.
This also helps preparing handle_migrate_data to be virtual.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
669df4fb38 red-channel-client: Make send_item a virtual function 
The items are send from RedChannelClient so move the callback
to a virtual function in RedChannelClient instead of RedChannel.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00
Frediano Ziglio
851696a645 red-channel-client: Preparation, rename send_item to avoid clash 
We will use this name for a virtual function from RedChannel.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
 2020-05-01 06:58:09 +01:00