From e9103c67addba3d3ac9cc2d2a45341a4489e0c71 Mon Sep 17 00:00:00 2001 From: Alon Levy Date: Mon, 8 Nov 2010 15:06:10 +0200 Subject: [PATCH] server/red_channel: add TODO --- server/red_channel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/red_channel.c b/server/red_channel.c index 2a7a5ff0..205eaf9f 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -64,6 +64,10 @@ static int red_peer_receive(RedsStreamContext *peer, uint8_t *buf, uint32_t size return pos - buf; } +// TODO: this implementation, as opposed to the old implementation in red_worker, +// does many calls to red_peer_receive and through it cb_read, and thus avoids pointer +// arithmetic for the case where a single cb_read could return multiple messages. But +// this is suboptimal potentially. Profile and consider fixing. static void red_peer_handle_incoming(RedsStreamContext *peer, IncomingHandler *handler) { int bytes_read;